Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenfactory before send hooks finalization #5725

Closed
Tracked by #5191
p0mvn opened this issue Jul 3, 2023 · 0 comments · Fixed by #5927
Closed
Tracked by #5191

Tokenfactory before send hooks finalization #5725

p0mvn opened this issue Jul 3, 2023 · 0 comments · Fixed by #5927
Assignees

Comments

@p0mvn
Copy link
Member

p0mvn commented Jul 3, 2023

Background

There are some bug fixes we want to get in before calling feature finishing token factory before send hook finalization.

  1. Check all module code is safe with send. cosmos-sdk side sends should be safe (we can check one more just to confirm) we want to go through Osmosis repo code base, see where we call bank sends and make sure wherever we call send is safe. Probably make a list of where we do module to module sends in either of Beginblock or Endblock then manually go one by one checking if they are safe.
  2. Track Before Send / Block Beforesend Infinite loop: Especially for module to module send because they don't have it gas metered. Ideal fix for this is to have constant gas meter either in token factory module or the bank module then consume gas manually in our logic on calling trackbeforesend.

Acceptance Criteria

  • Fixes for the problem statement mentioned above have been fixed
  • According test codes have been added
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Jul 3, 2023
@p0mvn p0mvn changed the title Tokenfactory before send hooks finalization (v17 scope) Tokenfactory before send hooks finalization Jul 18, 2023
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants