Implement job priorities in daily report #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Crola1702
force-pushed
the
Crola1702/implement-job-priorities
branch
from
28a857f
to
f7c9339
Compare
|
Generated reports: |
Blast545
approved these changes
Oct 18, 2024
Comment on lines
+1
to
+6
| SELECT job_name, | ||
| error_name | ||
| FROM test_fail_issues | ||
| WHERE github_issue = "@param1@" | ||
| GROUP BY github_issue, | ||
| job_name; |
There was a problem hiding this comment.
sql lgtm, but the name not completely, should it be something along the lines of get_known_issue_by_url?
| out | ||
| end | ||
|
|
||
| def self.issue_priority(issue_link) |
There was a problem hiding this comment.
calculate_issue_priority instead?
Comment on lines
+173
to
+174
| # Get only maximum score for each job | ||
| error_score_jobs.each_value.map {|e| e.max}.sum.round(3) |
There was a problem hiding this comment.
Why do we need the maximum here? If you are iterating over the error flakiness in each of the jobs, isn't the total priority of them the complete sum?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With a lot of new issues been created in the buildfarm for both ROS and Gazebo projects, a way to compare issues by importance or 'priority' is a good enhancement to get rid of most issues.
Changes
get_known_issue_errors.sqlto get the error names and jobs from a github issue linkjob_priorities.csvdefined from Buildfarm Issue Triage spreadsheet