Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reviewer/maintainer guidance/expectations #1552

Closed
justaugustus opened this issue Jan 27, 2022 · 3 comments
Closed

Reviewer/maintainer guidance/expectations #1552

justaugustus opened this issue Jan 27, 2022 · 3 comments
Assignees
@justaugustus
Labels
kind/docs Improvements or additions to documentation
Milestone
v5

Comments

@justaugustus
Copy link
Member

justaugustus commented Jan 27, 2022 •
edited
Loading

How can we guide contributors/maintainers in doing code reviews/maintaining the project?

@laurentsimon -- Another nit to briefly continue the convo from #1532 (comment):
The notes you left in the PR description are much clearer!

docs/checks.md: updated the doc
docs/checks/internal/checks.yaml: updated the source of truth for docs

What I was suggesting in the previous PR was to make these not the PR description, but the actual commit messages.
That way, when the PR content gets squashed and merged, the details get included as part of the git history.

Gocha. The info also seems useful for the PR reviewer. So need them in both places?

do you have a doc on updating a past commit? I can try adding it

Originally posted by @laurentsimon in #1545 (comment)
@justaugustus justaugustus added the kind/docs Improvements or additions to documentation label Jan 27, 2022
@justaugustus justaugustus mentioned this issue Jan 27, 2022
Closed
7 tasks
@justaugustus justaugustus added this to the v5 milestone Feb 22, 2022
@justaugustus justaugustus self-assigned this Feb 23, 2022
@github-actions
Copy link

Stale issue message

@github-actions
Copy link

Stale issue message

@github-actions github-actions bot closed this as completed Jul 4, 2022
@justaugustus justaugustus reopened this Sep 13, 2022
@github-actions
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justaugustus justaugustus

Labels
kind/docs Improvements or additions to documentation
Projects
None yet
Milestone
v5
Development

No branches or pull requests
2 participants
@justaugustus @azeemshaikh38