Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is property_path sound? #14

Open
bkircher opened this issue Jul 15, 2016 · 1 comment
Open

Is property_path sound? #14

bkircher opened this issue Jul 15, 2016 · 1 comment

Comments

@bkircher
Copy link
Collaborator

property_path, indexed_property_path, (and extended_property_path) are participants in a hierarchy. Why?

Also, we pass property_path by value (as a copy) in a lot of different places in the API, coercing indexed_property_path eventually.

Finally, property_path::field_uri is used in different places, with <FieldURI="" /> hand-coded. Other types in the API provide a to_xml member-function. Consider adding to_xml to property_path. You could circumvent the type coercion problem by using a closure (std::function) internally.

@bkircher
Copy link
Collaborator Author

This is addressed in PR #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant