AO3-6152 Update mimemagic #3986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the latest 0.3.x version (because all the previous versions have been removed). The gem mimemagic, that is a dependency of Rails, was using the MIT license, but distributing a file that falls under the GPL. (mimemagicrb/mimemagic#97) The maintainer has updated the license to GPL-2.0 and yanked all the older versions of the gem. The Archive code is already using GPL-2, so we don't need to change anything to continue using this gem, but we need to use a version that exists in rubygems so our builds don't fail.
CristinaRO
force-pushed
the
AO3-xxxx-update-mimemagic
branch
from
820dd9c to
bebbdfb
Compare
redsummernight
approved these changes
Mar 26, 2021
redsummernight
added
Reviewed: Ready to Merge
Reviewed: Action Needed
and removed
Awaiting Review
Reviewed: Ready to Merge
labels
|
mimemagic 0.3.6 has been removed. Instead, let's update Rails to 5.2.5, which removes mimemagic as a dependency. |
|
#3988 replaces this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Use the latest 0.3.x version (because all the previous versions have been removed).
The gem mimemagic, that is a dependency of Rails, was using the MIT license, but distributing a file that falls under the GPL. (mimemagicrb/mimemagic#97)
The maintainer has updated the license to GPL-2.0 and yanked all the older versions of the gem.
The Archive code is already using GPL-2, so we don't need to change anything to continue using this gem, but we need to use a version that exists in rubygems so our builds don't fail.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6152
Testing Instructions
How can the Archive's QA team verify that this is working as you intended?
Not user-facing.
(If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions.)
References
Are there other relevant issues/pull requests/mailing list discussions?
Credit
What name do you want us to use to credit your work in the Archive of Our Own's Release Notes?