You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I run ./scripts/run-tests.sh, all tests show PASSED except two:
tests/test_metrics.py::test_nubia FAILED
tests/test_metrics.py::test_gold_paragraphs SKIPPED (Parses all PDFs - very slow)
test_nubia fails with an obscure pydantic validation error, I had to add a print to understand the problem. How about adding @mark.skipif(not settings.OUGHT_INFERENCE_API_KEY, reason='...')?
Both tests have @mark.slow but this doesn't do anything by default. I assume this is why test_gold_paragraphs has a hard @mark.skip. This doesn't seem great - what do you do when you actually want to run the test? Should a way to skip slow tests by default (with or without using @mark.slow) be investigated?
-m 'not slow' correctly deselects the slow tests, but only if I directly run docker compose and pytest. ./scripts/run-tests.sh -m 'not slow' doesn't work, and the shell (tested both bash and zsh) shows it running with -m 'not\' slow. Looks like this isn't working:
When I run
./scripts/run-tests.sh
, all tests show PASSED except two:test_nubia
fails with an obscure pydantic validation error, I had to add a print to understand the problem. How about adding@mark.skipif(not settings.OUGHT_INFERENCE_API_KEY, reason='...')
?@mark.slow
but this doesn't do anything by default. I assume this is whytest_gold_paragraphs
has a hard@mark.skip
. This doesn't seem great - what do you do when you actually want to run the test? Should a way to skip slow tests by default (with or without using@mark.slow
) be investigated?-m 'not slow'
correctly deselects the slow tests, but only if I directly run docker compose and pytest../scripts/run-tests.sh -m 'not slow'
doesn't work, and the shell (tested both bash and zsh) shows it running with-m 'not\' slow
. Looks like this isn't working:ice/scripts/run-tests.sh
Lines 8 to 9 in 7eab90d
The text was updated successfully, but these errors were encountered: