Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters disappearing on resources which aren't using detached filters #17

Closed
goldmerc opened this issue Feb 23, 2021 · 5 comments
Closed

Comments

@goldmerc
Copy link

I just noticed that my resources which aren't using a NovaDetachedFilters card are losing their filters from the the standard Nova filter dropdown.

If I add the HasDetachedFilters trait to the resource class, the filter re-appears in the standard dropdown.

Is this the intended behaviour?

Thanks

@LouisHrg
Copy link

I second this, the package is breaking every filters in my applications (I use it in 4 production applications). I'll try to do a PR if I manage to find the time

@KasparRosin
Copy link
Member

@KasparRosin
Copy link
Member

@LouisHrg If you can create a pull request, i'll merge it.

If i have some time in the future, i'll try to find a solution that wont result in having to override filter-menu component.

@AhmedSHelmi
Copy link

any updates on this issue?

@KasparRosin
Copy link
Member

Released version 1.0.13 that should fix this issue.

Let me know if there are any more problems!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants