Skip to content
This repository has been archived by the owner on Sep 18, 2019. It is now read-only.

new Buffer() is deprecated and it's unsafe. #631

Closed
idandagan1 opened this issue Feb 18, 2018 · 2 comments
Closed

new Buffer() is deprecated and it's unsafe. #631

idandagan1 opened this issue Feb 18, 2018 · 2 comments

Comments

@idandagan1
Copy link

Hi,
In the file core.js there is a use of new Buffer() although it is deprecated.
using Buffer is unsafe and can cause security issues (Link)

I can open a PR for that.
@devinivy
Copy link

Feel free to open a PR—seems like a great first contribution to me!

@idandagan1 idandagan1 mentioned this issue Feb 18, 2018
Merged
@idandagan1
Copy link
Author

I've open a PR - Replace new Buffer() #3741

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hueniverse @devinivy @idandagan1