ProtobufJS doesn't properly serialise messages

[l1mey112]

What version of Bun is running?

1.1.4+fbe2fe0c3

What platform is your computer?

Linux 6.9.1-arch1-2 x86_64 unknown

What steps can reproduce the bug?

Entire MRE project: test.zip

import { load } from "protobufjs"

const sp = await load(`${import.meta.dir}/sp.proto`)
const signup = sp.lookupType('SignUpRequest')

const msg = {
	url: 'https://auth-callback.spotify.com/r/ios/music/signup',
	tag2: {
		username: 'test',
		dob: `2000-00-00`,
		gender: 1,
		tag4: {
			tag1: {
				blank_tag1: 1
			},
			tag2: {},
			tag3: {},
		},
		tag101: {
			signupemail: 'test@gmail.com',
			password: 'test',
		},
	},
	tag3: {
		client_id: 'test',
		os: 'test',
		appversion: '8.8.54',
		stringoffset: 1,
		random_hex32: 'testing',
	},
	tag4: {
		client_mobile: 'client_mobile',
	},
}

const message = signup.fromObject(msg)
const buf = signup.encode(message).finish()

const message2 = signup.decode(buf)
console.log(message2.toJSON()) // INCORRECT MESSAGE

What is the expected behavior?

Correct printout exactly as encoded.

What do you see instead?

A couple fields are missing:

{
  url: "https://auth-callback.spotify.com/r/ios/music/signup",
  tag2: {
    username: "test",
    dob: "2000-00-00",
    gender: 1,
    tag4: {
      tag1: [Object ...],
      tag2: [Object ...],
      tag3: [Object ...],
    },
    tag101: {
      signupemail: "test@gmail.com",
      password: "test",
    },
  },
  tag3: {
    os: "test",
    appversion: "8.8.54",
    stringoffset: 1,
  },
  tag4: {},
}

Additional information

This might fix #11633 as librespot uses this exact library.

[Jarred-Sumner]

Not a bug in Bun, as Node & Bun produce identical output:

❯ node index.mjs | shasum
4a29eb0666cf574f845e089689e969d1100cb890  -

❯ bun index.mjs | shasum
4a29eb0666cf574f845e089689e969d1100cb890  -

import { createRequire } from "module";

const require = createRequire(import.meta.url);

const { load } = require("protobufjs");

const sp = await load(`${import.meta.dirname}/sp.proto`);
const signup = sp.lookupType("SignUpRequest");

const msg = {
  url: "https://auth-callback.spotify.com/r/ios/music/signup",
  tag2: {
    username: "test",
    dob: `2000-00-00`,
    gender: 1,
    tag4: {
      tag1: {
        blank_tag1: 1,
      },
      tag2: {},
      tag3: {},
    },
    tag101: {
      signupemail: "test@gmail.com",
      password: "test",
    },
  },
  tag3: {
    client_id: "test",
    os: "test",
    appversion: "8.8.54",
    stringoffset: 1,
    random_hex32: "testing",
  },
  tag4: {
    client_mobile: "client_mobile",
  },
};

const message = signup.fromObject(msg);
const buf = signup.encode(message).finish();

const message2 = signup.decode(buf);
process.stdout.write(JSON.stringify(message2.toJSON()));

[sirenkovladd]

protobufjs/protobuf.js#564

this object works

const msg = {
  	url: 'https://auth-callback.spotify.com/r/ios/music/signup',
  	tag2: {
  		username: 'test',
  		dob: `2000-00-00`,
  		gender: 1,
  		tag4: {
  			tag1: {
  				blankTag1: 1
  			},
  			tag2: {},
  			tag3: {},
  		},
  		tag101: {
  			signupemail: 'test@gmail.com',
  			password: 'test',
  		},
  	},
  	tag3: {
  		clientId: 'test',
  		os: 'test',
  		appversion: '8.8.54',
  		stringoffset: 1,
  		randomHex32: 'testing',
  	},
  	tag4: {
  		clientMobile: 'client_mobile',
  	},
  }