-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dgram #1630
Comments
Yes please! I'm working on an open source UPnP server package which uses dgram for some of its connection backend. It would be great if we could take advantage of bun's much improved speed in sqlite3 and general code execution, but we can't yet until dgram is implemented. |
This would also be nice to have for using @discordjs/voice to stream audio (especially since ytdl-core is working now) |
@Jarred-Sumner How's this going? |
Just tested some of my code again on bun 0.7.4 and this is needed. Kudos. |
I've just tried on Bun 0.8 without any luck: This seems to be the blocker for one of our app. |
This would be awesome for discord/voice, waiting for this! |
Yes. I'm have some difficult to use discord/voice or discord-player. |
I tried Bun 1.0 but it looks like our https://www.npmjs.com/package/hot-shots dependency doesn't work due to lack of |
Well maybe we can start the discussion of whats needed to implement. Cursory look at the node docs for dgram shows 1 type (Socket) with 19 methods, 5 events, and 2 constructors. |
node-ssdp relies on dgram |
also bittorrent-dht relies on dgram. |
discord voice protocol uses UDP, @discordjs/voice uses dgram, this should be done ASAP (after bug fixes) |
I reviewed #159, but it seems like this is not on the roadmap, is it? @Jarred-Sumner |
Came here looking for this since it's a blocking issue for doing all sorts of IoT stuff. |
I would really need it for Webtorrent. 🙏 |
Bun can't be a drop-in replacement for really any of my projects without dgram support since we use dd-trace and hot-shots. |
Does anyone working on this? I could try implement something... |
A quick note: UDP support also implies multicast ;) |
this library that I want to use https://github.com/alxhotel/chromecast-api needs this |
A lot of us working with IoT and robotics really need this. I hope it gets prioritized, since is not on the roadmap (as in #159 ) |
Up! Really need this for Bonjour (mDNS) |
Looking forward to the datagram. |
Up |
It would be great for IoT ad-hoc servers listening for UDP messages. Thanks. |
As a temporary solution, this can be implemented via FFI |
@jadbox it‘s not a bug, simply not implemented as described in the documentation. |
Um. It seems to me that "not implemented as described in the documentation" would require either fixing the module so it does what the documentation describes or the documentation needs to be changed so it reflects the correct operation of the module. So, yes, I'd say it's a bug. :) |
@rob-raisch-simplisafe UDP is not in the documentation, so there is no bug or error in the documentation. It is not listed as something that is supported. This issue tracks support for UDP. As @jedahan said, you are welcome to pick up where #7271 left off, or start from scratch. And, of course, if you see an error in the documentation, please open a pull request. |
Thanks for the clarification. |
@rob-raisch-simplisafe The documentation I have written about, is this one: |
I'm willing to set a bounty, paid in XMR, for someone that can get a PR merged as soon as possible. |
👀 crypto has entered the house! 🙃. |
+1 |
Would be great to see support for this, along with node:cluster. |
Being unable to use |
Is the core team working on this @Jarred-Sumner Also, is anyone in the community actively working on this? Happy to take a stab otherwise. |
Despite of the excellent job being done by the Bun team, this feature should be top priority by now. This "bun shell" thing should have take a lot of effort to accomplish and at least for me, I don't see it being more critical for server-side software development than one of the most important network protocols in the world. Maybe I'm too dumb to see the real potential of bun shell, but IMO bun should focus on features that would really bring the community into Bun. |
@sharathprabhal I don't believe that anyone is working on it currently. If you (or anyone else) can successfully get a PR merged, I will pay some XMR. |
@recanman I'm working on this right now |
Much appreciated! 🙏 the community will love this |
A good test case would be this simple example: import util from 'node:util';
import nslookup from 'nslookup';
const debuglog = util.debuglog('test');
const domain = 'example.com';
debuglog('Looking up', domain);
nslookup(domain)
.server('208.67.222.123')
.type('a')
.timeout(10 * 1000)
.end(function(error, address) {
debuglog('got ip', address[0], 'for', domain);
}); To test this
|
Why is it closed if it's not fixed, @gvilums?
|
Have a little patience... The merge only has been done 7hours ago... Thanks for your work on this @gvilums ! |
Error 404: Patience not found! Oh, shite! I thought it was included in v1.1.5. |
This will be part of the Bun v1.1.6 release, which we are aiming to do later tonight |
It's a win, folks! 🎉 |
@gvilums Thank you very much. If you'd like the bounty, please post an XMR address |
Everyone wanting to use dgram, be advised that multicast UDP is not implemented yet: #10381 |
No description provided.
The text was updated successfully, but these errors were encountered: