unref() missing on HttpServer

[weyert]

What version of Bun is running?

1.0.2+37edd5a6e389265738e89265bcbdf2999cb81a49

What platform is your computer?

Darwin 22.6.0 arm64 arm

What steps can reproduce the bug?

Create a file with the following content:

require('http').createServer().unref()

Gives an error:

bun run ./poef.js
1 |
2 |   require("node:http").createServer().unref();
     ^
TypeError: require("node:http").createServer().unref is not a function. (In 'require("node:http").createServer().unref()', 'require("node:http").createServer().unref' is undefined)
      at /Users/weyert/poef.js:1:0
      at globalThis (/Users/weyert/poef.js:1:37)

What is the expected behavior?

I would expect the error not to be thrown

What do you see instead?

TypeError: require("node:http").createServer().unref is not a function. (In 'require("node:http").createServer().unref()', 'require("node:http").createServer().unref' is undefined)

Additional information

I was trying out whether OpenTelemetry is working through Bun but I am getting the above error when trying to create an instance of the PrometheusError which uses the above unref() call.

Original error I received was:

88 |         this._appendTimestamp =
89 |             typeof config.appendTimestamp === 'boolean'
90 |                 ? config.appendTimestamp
91 |                 : PrometheusExporter.DEFAULT_OPTIONS.appendTimestamp;
92 |         // unref to prevent prometheus exporter from holding the process open on exit
93 |         this._server = (0, http_1.createServer)(this._requestHandler).unref();
                ^
TypeError: (0, http_1.createServer)(this._requestHandler).unref is not a function. (In '(0, http_1.createServer)(this._requestHandler).unref()', '(0, http_1.createServer)(this._requestHandler).unref' is undefined)
      at new PrometheusExporter (/Users/weyert/Development/Project/node_modules/.pnpm/@opentelemetry+exporter-prometheus@0.41.2_@opentelemetry+api@1.4.1/node_modules/@opentelemetry/exporter-prometheus/build/src/PrometheusExporter.js:93:13)
      at configureMetricExporter (/Users/weyert/Development/Project/packages/opentelemetry-launcher/dist/launcher.js:356:30)
      at configureOpenTelemetry (/Users/weyert/Development/Project/packages/opentelemetry-launcher/dist/launcher.js:111:4)
      at /Users/weyert/Development/Project/services/service/dist/bootstrap.js:43:12
      at globalThis (/Users/weyert/Development/Project/services/service/dist/boot

[weyert]

For an example, how it is used in a production project:
https://github.com/weyert/bun-opentelemetry/blob/main/README.md

Retested in 1.0.2+37edd5a6e389265738e89265bcbdf2999cb81a49 still occurs

[cs01]

I just ran into this on 1.0.4.

[MarcStdt]

Still an issue in 1.0.20.
This breaks the usage of open-telemetry (prometheus exporter) for me.

[chlorophant]

Still an issue for me as well.