Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIFs, APNGs not animated in new chat #1258

Open
Tracked by #1261
BLKZOR opened this issue Nov 25, 2024 · 1 comment · May be fixed by #1261
Open
Tracked by #1261

GIFs, APNGs not animated in new chat #1258

BLKZOR opened this issue Nov 25, 2024 · 1 comment · May be fixed by #1261
Assignees
Labels
bug Something isn't working

Comments

@BLKZOR
Copy link

BLKZOR commented Nov 25, 2024

The following GIF and APNG images were animated in the previous chat (FloofChat.js), but are no longer animated in the new chat (armord_chat.js).

https://upload.wikimedia.org/wikipedia/commons/1/14/Animated_PNG_example_bouncing_beach_ball.png
https://upload.wikimedia.org/wikipedia/commons/3/31/Eokxd.gif

@Armored-Dragon Armored-Dragon self-assigned this Nov 26, 2024
@Armored-Dragon Armored-Dragon added the bug Something isn't working label Nov 26, 2024
@Armored-Dragon Armored-Dragon linked a pull request Nov 30, 2024 that will close this issue
9 tasks
@Armored-Dragon
Copy link
Member

The QT version we have does not seem to support animated .png. FloofChat was able to support APNGs because that chat was using the browser engine to render the display. Since DomainChat is using pure QT, there might be some weird quirks in the transition.
I have since added support for animated files in this commit to this pull request. This support unfortunately does not seem to function with animated PNGs. If our implementation of QT changes, namely we install a plugin to support .apng or QT itself gets support, the implementation inside of DomainChat should function as soon as it is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants