Dark Themes - Colourise Pull Request List Icons

[Sayvai]

Description

When viewing the Pull Requests GitHub page (and PR lists page), the mini Failed, Pass, and even the Merge icons are de-colourised for each Pull Request listed when using any of the Dark themes (eg, Monokai).

It makes it hard to distinguish between Pull Requests which have failed, or passed the automated build checks (eg, Jenkins tests) integrated into the repositories (if applicable).

A suggestion is to at least maintain the same colour to the icons that is visible when no colour theme is set (eg, red for Failed, Green for Passed, and also Green for the Merge icon to the left of the Pull Request title)

Environment (if bug)

• Octotree version: 5.0.0
• Browser & version: 83.0.4103.61
• OS & version: OS X 10.15.5 (Catalina)
• Screenshot:
  

• Console error log below this line: N/A

[buunguyen]

Fixed in 5.0

[Sayvai]

Fixed in 5.0

@buunguyen Really? But i am on version 5.0.0, as i have stated in the issue description, and i add my screenshot below.

I don't think this has really been investigated, and just immediately assumed. Is this how issues are generally dealt with on this project? Wow.. 😞

[buunguyen]

Sorry I was commenting on the wrong issue. This is not fixed.

[Sayvai]

Thank you 👍

[JoepKockelkorn]

I can confirm this bug on version 5.0.0. It seems the css selectors for the themes are too generic, or are missing modifiers for the 'open' or 'approved' state of icons. For the Railscasts theme these are some fixes I applied myself using the Stylus extension for the 'open' PR's in the PR overview and the approval icons in a PR:

html.octotree-theme-railscasts svg.open {
  fill: rgb(108, 198, 68);
}

html.octotree-theme-railscasts .TimelineItem-badge.bg-green {
  background-color: rgb(51, 119, 51) !important;
}

[buunguyen]

We use the theme files from https://github.com/StylishThemes/GitHub-Dark. We'll need to figure out if the problem is caused by the source theme files or only an problem when applied in Octotree. If the former, best to open an issue in GitHub Dark instead.

[AlecRust]

Apparently these are green in GitHub-Dark:

StylishThemes/GitHub-Dark#1117 (comment)

How recent is the GitHub-Dark version in Octotree, does it just need to be updated?

[buunguyen]

Fixed in 5.2.1

[Sayvai]

@buunguyen i've just verified the colours are restored correctly now. Many thanks for your work on the fix 👍

[buunguyen]

@Sayvai thanks for confirming, glad to hear.