Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1][win] Disabling VFS deletes the dehydrated files #11331

Closed
2 tasks done
saw-jan opened this issue Nov 3, 2023 · 1 comment · Fixed by #11334
Closed
2 tasks done

[5.1][win] Disabling VFS deletes the dehydrated files #11331

saw-jan opened this issue Nov 3, 2023 · 1 comment · Fixed by #11334
Assignees
@TheOneRing
Labels
p1-urgent Consider a hotfix release with only that fix (ex: lose trust, money, security issue, ...) type:bug
Milestone
Desktop 5.0

Comments

@saw-jan
Copy link
Member

saw-jan commented Nov 3, 2023 •
edited
Loading

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

Disabling VFS deletes all the dehydrated files (files with cloud icon) but files that are already downloaded still do not get deleted. Files are also deleted from the server

Expected behavior

Download the cloud files

Steps to reproduce the issue

  1. Upload some files and a folder with some files in it
  2. Install client 5.1 (https://download.owncloud.com/desktop/ownCloud/testing/5.1.0.12543/win/)
  3. Add account - VFS enabled
  4. Open some files from file-manager
  5. Disabled VFS in client (:x: dehydrated files get deleted)

Screenshots

Screenshot from 2023-11-03 14-19-20 Screenshot from 2023-11-03 14-19-32

Logs

ownCloud.log

Client version number

ownCloud 5.1.0.12543 652b67
Libraries Qt 6.4.3, OpenSSL 3.1.2 1 Aug 2023
Using virtual files plugin: wincfapi
OS: windows-10.0.22621
QPA: windows

Installation path (Windows only)

WIndows 11
@HanaGemela HanaGemela added this to the Inbox milestone Nov 3, 2023
@HanaGemela HanaGemela added the p2-high Escalation, on top of current planning, release blocker label Nov 3, 2023
@TheOneRing TheOneRing added p1-urgent Consider a hotfix release with only that fix (ex: lose trust, money, security issue, ...) and removed p2-high Escalation, on top of current planning, release blocker labels Nov 3, 2023
@TheOneRing TheOneRing self-assigned this Nov 3, 2023
@TheOneRing TheOneRing modified the milestones: Inbox, Desktop 5.0 Nov 3, 2023
@TheOneRing TheOneRing linked a pull request Nov 3, 2023 that will close this issue
Fix file deletion of vfs switch #11334
Merged
@HanaGemela HanaGemela mentioned this issue Nov 6, 2023
Closed
60 tasks
@HanaGemela
Copy link
Contributor

Passed in 5.1.1 rc1 win

@saw-jan saw-jan mentioned this issue Jan 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheOneRing TheOneRing

Labels
p1-urgent Consider a hotfix release with only that fix (ex: lose trust, money, security issue, ...) type:bug
Projects
None yet
Milestone
Desktop 5.0
Development

Successfully merging a pull request may close this issue.

Fix file deletion of vfs switch owncloud/client
3 participants
@TheOneRing @HanaGemela @saw-jan