Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle server error in setup wizard #11424

Closed
TheOneRing opened this issue Dec 6, 2023 · 4 comments · Fixed by #11482
Closed

Handle server error in setup wizard #11424

TheOneRing opened this issue Dec 6, 2023 · 4 comments · Fixed by #11482
Assignees
@TheOneRing
Labels
p2-high Escalation, on top of current planning, release blocker
Milestone
Desktop 6.0

Comments

@TheOneRing
Copy link
Member

TheOneRing commented Dec 6, 2023 •
edited
Loading

client/src/gui/owncloudgui.cpp

Line 855 in d452430

if (OC_ENSURE(status == ConnectionValidator::Connected || status == ConnectionValidator::ServerVersionMismatch)) {

The current code just ignores errors.
@TheOneRing TheOneRing added this to the Desktop 6.0 milestone Dec 6, 2023
@TheOneRing TheOneRing added the p2-high Escalation, on top of current planning, release blocker label Dec 19, 2023
@TheOneRing TheOneRing self-assigned this Dec 19, 2023
@TheOneRing TheOneRing mentioned this issue Jan 18, 2024
Merged
@saw-jan
Copy link
Member

saw-jan commented Jan 22, 2024

Any way we can confirm this?
CC @TheOneRing

@TheOneRing
Copy link
Member Author

I modified the user agent to report a 2.0 client. Which causes the server to block the client.

@saw-jan
Copy link
Member

saw-jan commented Feb 2, 2024

Any steps that we can test it?
Or we can move it to the Done if you have done already

@TheOneRing
Copy link
Member Author

Lets move it to done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheOneRing TheOneRing

Labels
p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Milestone
Desktop 6.0
Development

Successfully merging a pull request may close this issue.

Handle 403 errors owncloud/client
2 participants
@TheOneRing @saw-jan