Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow .well-known/openid-configuration -> token_endpoint_auth_methods_supported #11646

Closed
TheOneRing opened this issue May 21, 2024 · 2 comments · Fixed by #11647
Closed

Follow .well-known/openid-configuration -> token_endpoint_auth_methods_supported #11646

TheOneRing opened this issue May 21, 2024 · 2 comments · Fixed by #11647
Labels
p1-urgent Consider a hotfix release with only that fix (ex: lose trust, money, security issue, ...)

Comments

@TheOneRing
Copy link
Member

At the moment we send the client id and secret as a basic auth header as well as a post parameter.

We should read the token_endpoint_auth_methods_supported field of the well-known endpoint and only use one.
"client_secret_basic",
"client_secret_post",

Else "Active Directory Federation Service" will respond with Error when getting the accessToken "Fehler vom Server zurückgegeben: <em>MSIS9631: Received invalid OAuth request. Multiple client authentication methods were attempted.</em>"

@butonic
Copy link
Member

butonic commented May 21, 2024

I'd prefer checking if client_secret_basic is supported and fall back to client_secret_post if not. Aside from client_secret_jwt ... dunno when that is used.

looking at what a bank has to say https://directory.openbanking.org.uk/obieservicedesk/s/article/Can-you-explain-the-different-Token-endpoint-authentication-methods-And-they-preferred-secure-method I'd go with client_secret_basic first.

@TheOneRing TheOneRing added the p1-urgent Consider a hotfix release with only that fix (ex: lose trust, money, security issue, ...) label May 21, 2024
@TheOneRing TheOneRing linked a pull request May 22, 2024 that will close this issue
@dj4oC
Copy link

dj4oC commented May 23, 2024

Test result:
Client shows "Fertiggestellt" and "Failed to look up instances: Die Benutzerinformationen konnten nicht abgerufen werden."
If you click on "Abgeschlossen" client is working fine.

However: if you close the client and reopen it, you need to login again: "Der Benutzer LGTE, @.apps.-dev01..**.de ist ausgeloggt. Bitte über den Browser authentifizieren.

Logs are available, please ping me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-urgent Consider a hotfix release with only that fix (ex: lose trust, money, security issue, ...)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants