Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocqt562-qt5-qtbase fails to compile on Fedora 26 #5945

Closed
jnweiger opened this issue Aug 9, 2017 · 11 comments
Closed

ocqt562-qt5-qtbase fails to compile on Fedora 26 #5945

jnweiger opened this issue Aug 9, 2017 · 11 comments
Assignees

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Aug 9, 2017

API breakage: old qt562 does not support new openssl-110, support for the openssl-110 api is needed.

https://kanboard.owncloud.com/project/1/task/922

@jnweiger jnweiger self-assigned this Aug 9, 2017
@jnweiger
Copy link
Contributor Author

jnweiger commented Aug 9, 2017

@guruz @michaelstingl is this a blocker for 2.3.3 ?

@SamuAlfageme
Copy link
Contributor

@jnweiger @dschmidt already dealt with this for Debian 9 and fixed it last week:

dschmidt 10:33 AM  https://build.opensuse.org/package/rdiff/isv:ownCloud:devel:Qt562:templatized/ocqt562-qt5-qtbase?linkrev=base&rev=10
 
dschmidt 10:35 AM  basically qt tried to load openssl at runtime (via dlopen) and failed to do so ... because debian comes with libssl1.1 nowadays, which Qt (5.6 at least) does not support

dschmidt 10:35 AM  so i needed to install libssl1.0 and it worked

dschmidt 10:36 AM  now i changed the qt package recipe to link against ssl which should pull in the dep on installation automatically ... this is the slower approach than hacking a libssl requirement into the owncloud spec file... but also the more robust one

A pretty dummy sanity-check was also included on the after-install scripts that run on all package installation tests: https://gitlab.com/alfageme/client-linux-tests/blob/release_2.3.3/after_install/no_qssl_unresolved.sh

@michaelstingl
Copy link
Contributor

Is adding support for Fedora 26 a matter of a few days, or do you think is is a bigger issue. I think it's no big deal to add F26 builds a few days later…

@jnweiger
Copy link
Contributor Author

jnweiger commented Aug 9, 2017

seen on debian 9:

ldd /usr/bin/owncloud
...
        libssl.so.1.1 => /lib/x86_64-linux-gnu/libssl.so.1.1 (0x00007f4c06898000)
        libcrypto.so.1.1 => /lib/x86_64-linux-gnu/libcrypto.so.1.1 (0x00007f4c06403000)
...
        libssl.so.1.0.2 => /lib/x86_64-linux-gnu/libssl.so.1.0.2 (0x00007f4c02beb000)
        libcrypto.so.1.0.2 => /lib/x86_64-linux-gnu/libcrypto.so.1.0.2 (0x00007f4c02785000)

dpkg -l | grep libssl
ii  libssl1.0.2:amd64                 1.0.2l-2                       
ii  libssl1.1:amd64                   1.1.0f-3                       

Debian 9 provides two versions of libssl that can be nicely installed in parallel.

Fedora26 has

openssl-libs-1.1.0f-7.fc26.x86_64
compat-openssl10-1.0.2j-6.fc26.x86_64

that should allow the same trick.

@jnweiger jnweiger changed the title qt562-qt5-qtbase fails to compile on Fedora 26 ocqt562-qt5-qtbase fails to compile on Fedora 26 Aug 9, 2017
@guruz
Copy link
Contributor

guruz commented Aug 10, 2017

We can still announce the rc1 today and have the fedora builds only published after you guys fixed it?

@jnweiger
Copy link
Contributor Author

Yes. Go ahead. Just don't mention that it is missing - I see no more blockers, except kindergarden obs errors that I need to workaround the usual way. Matter of minutes of my time scattered over matter of hours and hours of rebuild attempts for obs.

@jnweiger
Copy link
Contributor Author

jnweiger commented Aug 10, 2017

ocqt562-qt5-qtbase builds. OBS now fails on qtwebkit, where it complains that a 600MB log file is too big.
Applying -Wno-expansion-to-defined

@guruz
Copy link
Contributor

guruz commented Aug 11, 2017

@jnweiger URL? :)

FYI @jturcotte

@jnweiger
Copy link
Contributor Author

jnweiger commented Aug 11, 2017

URL: e.g. https://build.opensuse.org/package/show/isv:ownCloud:testpilot:nightly/testpilotcloud-client
(for the reference only)

FIXED: All OBS nightly and testing obs projects now build 2.3.3-rc1 also for Fedora_26

btw: https://build.opensuse.org/package/show/isv:ownCloud:testpilot:edge/testpilotcloud-client-overlays (aka master nightly) no longer compiles on any platform:

[  165s] CMake Error at cmake/modules/QtVersionAbstraction.cmake:26 (message):
[  165s]   Qt5WebKit required for Shibboleth.  Use -DNO_SHIBBOLETH=1 to disable it.

@guruz
Copy link
Contributor

guruz commented Aug 14, 2017

Created #5957 for the edge/master build issue

@guruz guruz closed this as completed Aug 14, 2017
@ogoffart
Copy link
Contributor

If the distribution already has Qt >= 5.6, we should then not need to ship our own Qt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants