Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing notification when trying to download from unavailable storage #7460

Open
HanaGemela opened this issue Sep 6, 2019 · 2 comments
Open
Labels
feature:vfs native virtual files and placeholder implementation p3-medium Normal priority type:bug
Milestone

Comments

@HanaGemela
Copy link
Contributor

Found after testing #5088

Client: 2.6.0rc1 (build 12411)
mac 10.14.6
server: 10.2.0 stable

Steps to recreate:

  1. Start two servers:

docker run -e OWNCLOUD_SHARING_FEDERATION_ALLOW_HTTP_FALLBACK=true -p 8080:8080 owncloud/server
docker run -e OWNCLOUD_SHARING_FEDERATION_ALLOW_HTTP_FALLBACK=true -p 8081:8080 owncloud/server

  1. User1 shares a folder with User2 from another server (federated share)
  2. Turn off the first server
  3. User2 dehydrates the shared file
  4. User2 double clicks on the shared file to download it back

Actual result: Nothing
Expected result: Notification with explanation why the file cannot be downloaded

@HanaGemela HanaGemela added type:bug p3-medium Normal priority labels Sep 6, 2019
@HanaGemela HanaGemela added this to the 2.6.1 milestone Sep 6, 2019
@ogoffart ogoffart added the feature:vfs native virtual files and placeholder implementation label Oct 10, 2019
@ogoffart
Copy link
Contributor

So there isn't even a notification in the system tray that the sync failed? Maybe because we don't show error for temporarily unavailable files.

Application::openVirtualFile currently does not report any error, but i guess we should show a QMessageBox if there was an error. We can maybe try to get the error from the SyncResult::_syncItems that we have from the signal that the sync is finished

@michaelstingl michaelstingl modified the milestones: 2.6.1, 2.6.2 Nov 26, 2019
@michaelstingl
Copy link
Contributor

I'd expect at least an entry in the Activity > Not synced tab. Maybe some kind of notification can be shown somewhere…

@michaelstingl michaelstingl modified the milestones: 2.6.2, Backlog Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:vfs native virtual files and placeholder implementation p3-medium Normal priority type:bug
Projects
None yet
Development

No branches or pull requests

3 participants