Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] log lines are silently exposed via crash reporter #8955

Closed
jnweiger opened this issue Aug 26, 2021 · 5 comments
Closed

[QA] log lines are silently exposed via crash reporter #8955

jnweiger opened this issue Aug 26, 2021 · 5 comments

Comments

@jnweiger
Copy link
Contributor

Seen with client 2.9.0-beta3 on win10
while examining e.g. https://sentry.io/organizations/owncloud/issues/2604534440/events/090ac097fd434c719a989cf869e2ce86/?project=79001&statsPeriod=14d#extra

As per #8467 the crash report now contains 20 lines of log file contents.
This may expose server and user names involved, sensitive filenames, or possibly credentials.
The user is not informed that such data is included in the crash report. The user sees an empty text area when approving that the crash report should be sent.

Expected behaviour: The user can opt out or even better manually edit the log contents before sending.

@jnweiger jnweiger mentioned this issue Aug 26, 2021
39 tasks
@TheOneRing
Copy link
Member

It is not silently exposed its the comment field....

@TheOneRing
Copy link
Member

See #8469

@michaelstingl
Copy link
Contributor

See #8469

I didn't see content with the synthetic crash via owncloud --debug.

@TheOneRing
Copy link
Member

You'd need to crash with the "enforce" or "qFatal" crash

@michaelstingl
Copy link
Contributor

Yeah. looks good now 👍

CleanShot 2021-08-27 at 11 19 25

@jnweiger jnweiger mentioned this issue Dec 21, 2021
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants