[QA] pollintervall from server capabilities is ignored (msec vs sec confusion)

[jnweiger]

Seen in testpilotcloud 2.9.0-beta3 on Linux Mint 20.2

• server config.php with
  'pollinterval' => 122,

08-26 21:38:54:493 [ info sync.connectionvalidator ]:	Server capabilities QJsonObject({"checksums":{"preferredUploadType":"SHA1","supportedTypes":["SHA1"]},"core":{"pollinterval":122,"status": ...

But the client seems to poll every 30 seconds, nevertheless:

$ grep 'time since last' ~/testpilotcloud.log  
08-26 21:53:08:348 [ info gui.folder ]: Trying to check "https://12.23.34.45/remote.php/dav/files/jwtest/" for changes via ETag check. (time since last sync: 28 s)
08-26 21:53:39:347 [ info gui.folder ]: Trying to check "https://12.23.34.45/remote.php/dav/files/jwtest/" for changes via ETag check. (time since last sync: 59 s)
08-26 21:54:10:348 [ info gui.folder ]: Trying to check "https://12.23.34.45/remote.php/dav/files/jwtest/" for changes via ETag check. (time since last sync: 90 s)
08-26 21:54:41:347 [ info gui.folder ]: Trying to check "https://12.23.34.45/remote.php/dav/files/jwtest/" for changes via ETag check. (time since last sync: 121 s)
08-26 21:55:17:346 [ info gui.folder ]: Trying to check "https://12.23.34.45/remote.php/dav/files/jwtest/" for changes via ETag check. (time since last sync: 157 s)
08-26 21:55:48:347 [ info gui.folder ]: Trying to check "https://12.23.34.45/remote.php/dav/files/jwtest/" for changes via ETag check. (time since last sync: 188 s)
08-26 21:56:19:347 [ info gui.folder ]: Trying to check "https://12.23.34.45/remote.php/dav/files/jwtest/" for changes via ETag check. (time since last sync: 219 s)
08-26 21:56:50:347 [ info gui.folder ]: Trying to check "https://12.23.34.45/remote.php/dav/files/jwtest/" for changes via ETag check. (time since last sync: 250 s)
08-26 21:57:21:347 [ info gui.folder ]: Trying to check "https://12.23.34.45/remote.php/dav/files/jwtest/" for changes via ETag check. (time since last sync: 281 s)
08-26 21:57:52:347 [ info gui.folder ]: Trying to check "https://12.23.34.45/remote.php/dav/files/jwtest/" for changes via ETag check. (time since last sync: 312 s)
08-26 21:58:28:353 [ info gui.folder ]: Trying to check "https://12.23.34.45/remote.php/dav/files/jwtest/" for changes via ETag check. (time since last sync: 349 s)
08-26 21:58:59:347 [ info gui.folder ]: Trying to check "https://12.23.34.45/remote.php/dav/files/jwtest/" for changes via ETag check. (time since last sync: 379 s)
08-26 21:59:30:348 [ info gui.folder ]: Trying to check "https://12.23.34.45/remote.php/dav/files/jwtest/" for changes via ETag check. (time since last sync: 410 s)
08-26 22:00:01:346 [ info gui.folder ]: Trying to check "https://12.23.34.45/remote.php/dav/files/jwtest/" for changes via ETag check. (time since last sync: 441 s)

Expected behaviour: as per #8777 the server capabilitiy is honored.

[TheOneRing]

You set a pill interval of 122ms, everything < 5s will be ignored

[jnweiger]

That is bad. The server default was 60, so how should anybody get the Idea, that this is in milliseconds?

Server default is:

curl -s -u admin:admin 'https://demo.owncloud.com/ocs/v1.php/cloud/capabilities?format=json' | jq  .ocs.data.capabilities.core.pollinterval
 60

This value made me assume it is meant in units of seconds.
@felix-schwarz commented about this in #8777 (comment)
@michaelstingl can you confirm, how mobile clients interpret the value?
@mmattel FYI

[TheOneRing]

#8777 (comment)

Needs documentation

[mmattel]

@TheOneRing pls file a docs issue in the docs-client-desktop repo.

[TheOneRing]

@jnweiger when the topic of an issue drastically changes from EVERYTHING IS BROKEN to doc is missing please update the title of the issue to something meaning ful

[felix-schwarz]

@jnweiger I waited for the PR to be merged, then implemented the feature identically in the iOS client: owncloud/ios-app#1021

The only difference IIRC is that the iOS client will log a warning for values exceeding 60 seconds, in case someone added too many zeros and wonders why the client seemingly no longer refreshes.

[michaelstingl]

@TheOneRing pls file a docs issue in the docs-client-desktop repo.

@mmattel here we go:

• How to configure pollinterval capability to control desktop and iOS app docs-server#109
• Poll interval from capabilities docs-client-desktop#91
• Configurable poll interval docs-client-ios-app#1

[jnweiger]

Confirmed: The desktop client currently interprets the value as milliseconds.
If that is the correct interpretation, then we can close this issue here and follow up in the above doc issues. Thanks @michaelstingl

Please also note, that server 10.8 still sends a default capability of pollinterval:60 and does not document the parameter in the config.sample.php file...

[TheOneRing]

I think we discussed the issue in length, feel free to open a doc issue with the server.