Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IUserManager::find() when searching for members #106

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Use IUserManager::find() when searching for members #106

merged 1 commit into from
Sep 12, 2017

Conversation

PVince81
Copy link
Contributor

This makes sure that it will not only search the user id or display name
but also any search terms that might be defined for LDAP users.

Fixes #90

@PVince81 PVince81 added this to the QA milestone Sep 11, 2017
@PVince81 PVince81 self-assigned this Sep 11, 2017
@PVince81 PVince81 mentioned this pull request Sep 11, 2017
Closed
@PVince81
Copy link
Contributor Author

@phil-davis
Copy link
Contributor

@PVince81 a rebase of this should make Jenkins happy now. (ref #107 #108 )

Use IUserManager::find() when searching for members
1d0ebc8 
This makes sure that it will not only search the user id or display name
but also any search terms that might be defined for LDAP users.
@SergioBertolinSG
Copy link
Contributor

Works 👍

@PVince81
Copy link
Contributor Author

stalled build... will restart

@phil-davis phil-davis mentioned this pull request Sep 12, 2017
Closed
tomneedham
tomneedham approved these changes Sep 12, 2017
View reviewed changes
Copy link
Contributor

@tomneedham tomneedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit ee8b04a into master Sep 12, 2017
@PVince81 PVince81 deleted the memberautocomplete-usefind branch September 12, 2017 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomneedham tomneedham tomneedham approved these changes

@jvillafanez jvillafanez Awaiting requested review from jvillafanez

Assignees

@PVince81 PVince81

Labels
4 - To release
Projects
None yet
Milestone
0.3.5
Development

Successfully merging this pull request may close these issues.
4 participants
@PVince81 @phil-davis @SergioBertolinSG @tomneedham