Unit tests failing in oracle database

[dpakach]

when running unit tests in oracle database in drone this error occurs

1) OCA\CustomGroups\Tests\unit\CustomGroupsDatabaseHandlerTest::testGetGroupsByDisplayName
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'my_group_1'
+'my_group_3'

The drone link for this error is here

[PVince81]

hmmm, this sometimes happen if the unit tests are relying too much on database result order.
I might have missed doing this when writing them and it is known from experience that sometimes Oracle returns results out of order...

[PVince81]

@dpakach I assume you discovered this as part of your work in #173 ?

and perhaps we did not enable Oracle before so the issue was not discovered ?

in the future please link relevant tickets :-)

[dpakach]

@PVince81 yes, the tests which are in travis never used oracle so it might have missed before

[PVince81]

Fix is here: #187