-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POC] PROPFIND with Depth:infinity and streaming XML #950
Comments
no
infinity depth is in the code base since day one .... it was simply breaking apart until today ;-) but we can add a cap to tell client when to use this ..... |
@DeepDiver1975 Does it make sense to develop against owncloud/core#38583 yet? @michaelstingl I only need a server to develop and test against (or a way to set one up locally in a Ubuntu VM or Docker). |
yes |
I'll take care. |
@DeepDiver1975 Great! |
Okay, I performed the following steps in my Replace stable 10.7 with daily
|
I saw data streaming from the first second:
23444 items in 17 seconds doesn't sound too bad, and this was a tiny CPX11 Wölkchen from Hetzner (2vCPU, 2GB RAM, 40GB Disk space on local NVMe SSD) |
Detailed/full instructions for local Docker setup: Start local 10.7 Docker
Replace stable 10.7 with daily
|
I thought about the following error cases:
|
With respect to error handling this needs to be deeper worked on. In the non streaming case:
Current streaming case:
Possible solution I:
Possible solution II:
|
The PR for these changes: #1002 |
Results from bigger instancesResults from building and benchmarking different local Docker test environments:
Observations
Visual changesWith streaming parsing, statistics show almost immediately, so I added a title line to provide permanent context of what is going on: Configuration changesThe infinite
I also prepared support to allow enabling bookmark prepopulation via the capabilities. Since |
@felix-schwarz you can find the final capability here: owncloud/core#38583 (comment) |
@DeepDiver1975 did the server side arrive in the master branch? Link to pr/issue? Is there a capability for the clients, so they can check for such magic?
@felix-schwarz what else do you need to start a prototype implementation?
The text was updated successfully, but these errors were encountered: