-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numeric userid-username cannot be created #187
Comments
https://github.com/owncloud/ocis-accounts/blob/master/pkg/service/v0/accounts.go#L513 has:
It insists that a username/userid/email-address-first-part/whatever-you-call-it must start with an alpha or underscore. But that is just not true. For example a University I was enrolled at used the student number for usernames and email address - e.g. username "247843222" and email address "247843222@student.myuniversity.edu.au" - that all works fine for cloud file sharing in oC10, cs3org/reva and owncloud/ocis-reva. So, IMO, we better make sure it works for |
This change specifically restricted the username: https://github.com/owncloud/ocis-accounts/blob/master/changelog/0.2.0_2020-08-19/tighten-screws.md |
Maybe we now have the distinction between userid and username - maybe the userid can be numeric and the username will have to start with "[a-z][A-Z]_" - I will try making the test code do that and see what explodes. |
@butonic commented: hm, good point. I dug into the verification of unix usernames, because ultimately that username will appear as the username in an os that integrates with glauth to persist shares using acls. see https://unix.stackexchange.com/a/435120 and the systemd bug it caused: systemd/systemd#6237 |
I did a demonstration in owncloud/ocis#498 with core branch When creating users, the test code puts a "u" in front of the OCIS CI passes - good stuff. In oC10 Or we can relax the validation of username, or ...? |
Also, users with some special characters in their usernames cannot be created.
|
For example:
First need to look and see exactly what the test code is doing with these - maybe it is sending some not-allowed email address.
Then look to see if the code in
ocis-accounts
needs changing to allow "numeric" in userid-username-email.The text was updated successfully, but these errors were encountered: