Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ocis] Size Tree accounting - calculated folder sizes #1150

Closed
exalate-issue-sync bot opened this issue Dec 22, 2020 · 7 comments
Closed

[ocis] Size Tree accounting - calculated folder sizes #1150

exalate-issue-sync bot opened this issue Dec 22, 2020 · 7 comments
Labels
Type:Story User Story

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Dec 22, 2020

Story

As a user i want to know how big the folder is without browsing into it to quickly get an overview

Status quo

As of now folders are displayed with a size of 4KB in the web ui. This doesn't give a clue about actual folder sizes.

Performance

Make it work first
Performance later

@exalate-issue-sync
Copy link
Author

Michael Barz commented: [~jfd] In which storage driver scope was this ticket created?

@exalate-issue-sync exalate-issue-sync bot changed the title [ocis] Size Tree accounting [ocis] Size Tree accounting - calculated folder sizes Dec 22, 2020
@michaelstingl
Copy link
Contributor

michaelstingl commented Dec 22, 2020

I've seen this with owncloud.ocis.works

CleanShot 2020-12-22 at 00 44 14 CleanShot 2020-12-22 at 09 56 00
Web Desktop 2.7.4
2020-12-22 00 49 31 2020-12-22 00 49 23
Android 2.15.3 iOS 11.4.4

@abelgardep @jesmrec Android shows 0KB, while web and iOS show 4KB. What WebDAV property do we query here?

Hint from @butonic :

might be a difference in the webdav properties that are used. there is DAV:getcontentsize and oc10 introduced oc:size.
the latter is used to transport the 'tree size' and exists on folders as well as on files. DAV:getcontentsize is not defined for folders or in webdav speak: collections.

@abelgardep
Copy link

abelgardep commented Dec 22, 2020

We use oc:size in Android. The problem is a hardcoded DIR since ocis sends httpd/unix-directory. I will update it 👍

Should be fixed in owncloud/android#3040

@michaelstingl
Copy link
Contributor

In oC10, we also have folders with unknown size. Shouldn’t oCIS announce unknown size instead of the fake-4KB size?

@exalate-issue-sync
Copy link
Author

Jörn Friedrich Dreyer commented: implemented is part of querying the free space

@exalate-issue-sync
Copy link
Author

Jörn Friedrich Dreyer commented: PR in cs3org/reva#1405

@exalate-issue-sync
Copy link
Author

Jörn Friedrich Dreyer commented: cs3org/reva#1405 merged and updated in ocis with #1684

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
None yet
Development

No branches or pull requests

2 participants