Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion time in trash bin shows a wrong date #541

Closed
davitol opened this issue Sep 10, 2020 · 11 comments
Closed

Deletion time in trash bin shows a wrong date #541

davitol opened this issue Sep 10, 2020 · 11 comments
Assignees
Labels
Category:Defect Existing functionality is not working as expected Type:Bug

Comments

@davitol
Copy link
Contributor

davitol commented Sep 10, 2020

Tested with ocis-1.0.0-rc1 via https://gitea.owncloud.services/jw/hetzner/src/branch/master/make_ocis_eos_test.sh

Screenshot 2020-09-10 at 09 26 46

@settings settings bot removed the qa label Sep 23, 2020
@individual-it
Copy link
Member

tried on OCIS storage and it looks like the deletion-time is actually the mtime or the upload time

@individual-it
Copy link
Member

individual-it commented Dec 18, 2020

  • todo QA-Team: make API tests to check the deletion time.
    It's reported in the oc:trashbin-delete-datetime field when doing a PROPFIND on the trashbin endpoint. e.g.: curl 'http://localhost/owncloud-core/remote.php/dav/trash-bin/admin/' -uadmin:admin -X PROPFIND -d'<?xml version="1.0"?><d:propfind xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns"> <d:prop><oc:trashbin-original-filename /><oc:trashbin-original-location /><oc:trashbin-delete-datetime /><d:getcontentlength /> <d:resourcetype /></d:prop></d:propfind>'

@haribhandari07
Copy link
Contributor

Reminder to JankariTech Team: Swikriti and Sajan are working on this issue.

@refs
Copy link
Member

refs commented Jan 12, 2021

@haribhandari07 is this still relevant? :)

@individual-it
Copy link
Member

  • ToDo QA-team retest on EOS storage (most likely the issue still exists with EOS)

@refs refs changed the title Deletion time in trash bin shows a wrong date [EOS-storage] Deletion time in trash bin shows a wrong date Jan 12, 2021
@settings settings bot removed QA-Team labels Jan 12, 2021
@refs refs added Storage:EOS Category:Defect Existing functionality is not working as expected labels Jan 13, 2021
@saw-jan
Copy link
Member

saw-jan commented Jan 18, 2021

couldn't setup ocis with eos storage using docs from here
whenever STORAGE_HOME_DRIVER=eoshome is set, cannot upload files (upload button is disabled)
and cannot login after setting Metadata storage for eos

@refs refs changed the title [EOS-storage] Deletion time in trash bin shows a wrong date Deletion time in trash bin shows a wrong date Jan 18, 2021
@swoichha swoichha assigned haribhandari07 and unassigned saw-jan Jan 21, 2021
@individual-it
Copy link
Member

@ishank011 can you try to reproduce it, we fail to get EOS running

@ishank011
Copy link
Contributor

@individual-it will take a look. We start separate reva servers for the storage providers so there might be some things missing in the native ocis EOS providers.

Also, I'm not sure why the upload button is disabled, but this commit cs3org/reva#1415 is needed for uploads to go through, as we don't support TUS in EOS and we need to broadcast this to the clients.

@phil-davis
Copy link
Contributor

phil-davis commented May 19, 2022

This needs to be retried (after it sitting here for so long), and report back on what happens.

  • try with the "regular" oCIS storage and (hopefully) confirm that the issue was fixed
  • try with EOS storage and report back the result

We are not running EOS storage in test pipelines in CI, and that is not likely to happen any time soon. So we just need to report the current manual observations, then this can be either closed, or removed from the QA-team project(s).

@grgprarup
Copy link
Contributor

grgprarup commented Sep 20, 2022

This needs to be retried (after it sitting here for so long), and report back on what happens.

  • try with the "regular" oCIS storage and (hopefully) confirm that the issue was fixed
  • try with EOS storage and report back the result

We are not running EOS storage in test pipelines in CI, and that is not likely to happen any time soon. So we just need to report the current manual observations, then this can be either closed, or removed from the QA-team project(s).

Findings:

  • with regular oCIS storage the deletion time in the trash bin is working fine 👍

@individual-it
Copy link
Member

I think this can be closed for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Defect Existing functionality is not working as expected Type:Bug
Projects
None yet
Development

No branches or pull requests

9 participants