Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listing spaces makes subsequent requests #6158

Closed
2 tasks done
butonic opened this issue Apr 26, 2023 · 2 comments
Closed
2 tasks done

listing spaces makes subsequent requests #6158

butonic opened this issue Apr 26, 2023 · 2 comments

Comments

@butonic
Copy link
Member

butonic commented Apr 26, 2023

The graph /me/drives endpoint makes a ListStorageSpaces call and then:

  • a GetQuota call in drives.go:getDriveQuota() which we should fetch with the ListStorageSpaces call
  • a GetPath and a Stat call in driveItems.go:getSpecialDriveItem when fetching getExtendedSpaceProperties which we should either cache or receive from the initial ListStorageSpace call as well.

image

Related

#4586 tries to make requests cheaper by making fetching the root optional. BUt we still need to make these requests cheap as desktop clients will poll this endpoint

@butonic
Copy link
Member Author

butonic commented May 15, 2023

closing as

  • quota is now sent and fetched in opaque,
  • special items are now cached until the root changes

@butonic butonic closed this as completed May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

1 participant