Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the introductionVersion field to all existing environment variables #8434

Closed
dragonchaser opened this issue Feb 12, 2024 · 7 comments
Closed
Assignees

Comments

@dragonchaser
Copy link
Member

Prerequisite to #8258

  • Add the introductionVersion field to all existing environment variables
  • The value MUST be pre5.0 (all newer Variables get their correct value upon introduction) for all currently existing variables in all services.
  • This Task needs to be commited before release 5.0
@dragonchaser
Copy link
Member Author

A make target to validate the work can be found in #8436 just run make check-env-var-annotations from the project root.

@dragonchaser
Copy link
Member Author

Mentioned make target has been merged to master

@kulmann
Copy link
Member

kulmann commented Feb 14, 2024

@jacob-nv do you have capacity to look into this?

@kulmann
Copy link
Member

kulmann commented Feb 15, 2024

@individual-it @phil-davis do you guys have someone who could get this done quickly? It's a super easy task, busy work.

@phil-davis
Copy link
Contributor

@saw-jan I am having a look at what is involved in this. If it can be automated pretty well in the IDE then I might "just do it", or I will hand over for someone to do when I understand what variations there are that need to be "manually" edited.

@phil-davis
Copy link
Contributor

PR #8469 is ready for review and discussion.

@phil-davis
Copy link
Contributor

PR #8574 added this to ocis master.
Backport to stable-5.0 was done in PR #8583

make check-env-var-annotations was added to CI in both these PRs.

I think that this is done. @dragonchaser close? Or is there anything else to tweak?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants