From a1cf3b5590dc1c1f234a4000cb730b1104fcdafe Mon Sep 17 00:00:00 2001 From: Ilja Neumann Date: Thu, 21 Jan 2021 10:21:54 +0100 Subject: [PATCH 1/7] Update reva to v1.5.1 --- accounts/go.mod | 2 +- accounts/go.sum | 2 ++ ocs/go.mod | 2 +- ocs/go.sum | 2 ++ proxy/go.mod | 2 +- proxy/go.sum | 2 ++ storage/go.mod | 2 +- storage/go.sum | 2 ++ 8 files changed, 12 insertions(+), 4 deletions(-) diff --git a/accounts/go.mod b/accounts/go.mod index 0de5040a696..157c63c8ee4 100644 --- a/accounts/go.mod +++ b/accounts/go.mod @@ -7,7 +7,7 @@ require ( contrib.go.opencensus.io/exporter/ocagent v0.6.0 contrib.go.opencensus.io/exporter/zipkin v0.1.1 github.com/cs3org/go-cs3apis v0.0.0-20201118090759-87929f5bae21 - github.com/cs3org/reva v1.4.1-0.20210111080247-f2b63bfd6825 + github.com/cs3org/reva v1.5.1 github.com/go-chi/chi v4.1.2+incompatible github.com/go-chi/render v1.0.1 github.com/gofrs/uuid v3.3.0+incompatible diff --git a/accounts/go.sum b/accounts/go.sum index 7e8d684d23b..2d30192c7e6 100644 --- a/accounts/go.sum +++ b/accounts/go.sum @@ -187,6 +187,8 @@ github.com/cs3org/reva v1.2.2-0.20200924071957-e6676516e61e h1:khITGSnfDXtByQsLe github.com/cs3org/reva v1.2.2-0.20200924071957-e6676516e61e/go.mod h1:DOV5SjpOBKN+aWfOHLdA4KiLQkpyC786PQaXEdRAZ0M= github.com/cs3org/reva v1.4.1-0.20210111080247-f2b63bfd6825 h1:U6pAVGTjesstz+EXd8+YpIG1xwKH1ovOXdWrMCvnopw= github.com/cs3org/reva v1.4.1-0.20210111080247-f2b63bfd6825/go.mod h1:abC1Lo0ZKwkKloomTPZWunV/lUJvewkty1pI41zn2Ic= +github.com/cs3org/reva v1.5.1 h1:GebunCjhHfA3lFLXjQT+3jOUjEXUubk9sr3otOIDGac= +github.com/cs3org/reva v1.5.1/go.mod h1:abC1Lo0ZKwkKloomTPZWunV/lUJvewkty1pI41zn2Ic= github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= diff --git a/ocs/go.mod b/ocs/go.mod index 39e026add52..035cb45546b 100644 --- a/ocs/go.mod +++ b/ocs/go.mod @@ -8,7 +8,7 @@ require ( contrib.go.opencensus.io/exporter/zipkin v0.1.1 github.com/UnnoTed/fileb0x v1.1.4 github.com/cs3org/go-cs3apis v0.0.0-20201118090759-87929f5bae21 - github.com/cs3org/reva v1.4.1-0.20210111080247-f2b63bfd6825 + github.com/cs3org/reva v1.5.1 github.com/go-chi/chi v4.1.2+incompatible github.com/go-chi/render v1.0.1 github.com/golang/protobuf v1.4.3 diff --git a/ocs/go.sum b/ocs/go.sum index 9d50ace2682..ad1d3e34008 100644 --- a/ocs/go.sum +++ b/ocs/go.sum @@ -198,6 +198,8 @@ github.com/cs3org/go-cs3apis v0.0.0-20201118090759-87929f5bae21/go.mod h1:UXha4T github.com/cs3org/reva v1.2.2-0.20200924071957-e6676516e61e/go.mod h1:DOV5SjpOBKN+aWfOHLdA4KiLQkpyC786PQaXEdRAZ0M= github.com/cs3org/reva v1.4.1-0.20210111080247-f2b63bfd6825 h1:U6pAVGTjesstz+EXd8+YpIG1xwKH1ovOXdWrMCvnopw= github.com/cs3org/reva v1.4.1-0.20210111080247-f2b63bfd6825/go.mod h1:abC1Lo0ZKwkKloomTPZWunV/lUJvewkty1pI41zn2Ic= +github.com/cs3org/reva v1.5.1 h1:GebunCjhHfA3lFLXjQT+3jOUjEXUubk9sr3otOIDGac= +github.com/cs3org/reva v1.5.1/go.mod h1:abC1Lo0ZKwkKloomTPZWunV/lUJvewkty1pI41zn2Ic= github.com/cznic/b v0.0.0-20181122101859-a26611c4d92d/go.mod h1:URriBxXwVq5ijiJ12C7iIZqlA69nTlI+LgI6/pwftG8= github.com/cznic/mathutil v0.0.0-20181122101859-297441e03548/go.mod h1:e6NPNENfs9mPDVNRekM7lKScauxd5kXTr1Mfyig6TDM= github.com/cznic/strutil v0.0.0-20181122101858-275e90344537/go.mod h1:AHHPPPXTw0h6pVabbcbyGRK1DckRn7r/STdZEeIDzZc= diff --git a/proxy/go.mod b/proxy/go.mod index ade7f60b3c9..aa75e4b6ab2 100644 --- a/proxy/go.mod +++ b/proxy/go.mod @@ -8,7 +8,7 @@ require ( contrib.go.opencensus.io/exporter/zipkin v0.1.1 github.com/coreos/go-oidc v2.2.1+incompatible github.com/cs3org/go-cs3apis v0.0.0-20201118090759-87929f5bae21 - github.com/cs3org/reva v1.4.1-0.20210111080247-f2b63bfd6825 + github.com/cs3org/reva v1.5.1 github.com/dgrijalva/jwt-go v3.2.0+incompatible github.com/golang/mock v1.4.4 // indirect github.com/justinas/alice v1.2.0 diff --git a/proxy/go.sum b/proxy/go.sum index d6d933e5fe6..524895e2698 100644 --- a/proxy/go.sum +++ b/proxy/go.sum @@ -196,6 +196,8 @@ github.com/cs3org/go-cs3apis v0.0.0-20201118090759-87929f5bae21/go.mod h1:UXha4T github.com/cs3org/reva v1.2.2-0.20200924071957-e6676516e61e/go.mod h1:DOV5SjpOBKN+aWfOHLdA4KiLQkpyC786PQaXEdRAZ0M= github.com/cs3org/reva v1.4.1-0.20210111080247-f2b63bfd6825 h1:U6pAVGTjesstz+EXd8+YpIG1xwKH1ovOXdWrMCvnopw= github.com/cs3org/reva v1.4.1-0.20210111080247-f2b63bfd6825/go.mod h1:abC1Lo0ZKwkKloomTPZWunV/lUJvewkty1pI41zn2Ic= +github.com/cs3org/reva v1.5.1 h1:GebunCjhHfA3lFLXjQT+3jOUjEXUubk9sr3otOIDGac= +github.com/cs3org/reva v1.5.1/go.mod h1:abC1Lo0ZKwkKloomTPZWunV/lUJvewkty1pI41zn2Ic= github.com/cznic/b v0.0.0-20181122101859-a26611c4d92d/go.mod h1:URriBxXwVq5ijiJ12C7iIZqlA69nTlI+LgI6/pwftG8= github.com/cznic/mathutil v0.0.0-20181122101859-297441e03548/go.mod h1:e6NPNENfs9mPDVNRekM7lKScauxd5kXTr1Mfyig6TDM= github.com/cznic/strutil v0.0.0-20181122101858-275e90344537/go.mod h1:AHHPPPXTw0h6pVabbcbyGRK1DckRn7r/STdZEeIDzZc= diff --git a/storage/go.mod b/storage/go.mod index d0d253b868d..aeca7beb935 100644 --- a/storage/go.mod +++ b/storage/go.mod @@ -3,7 +3,7 @@ module github.com/owncloud/ocis/storage go 1.15 require ( - github.com/cs3org/reva v1.4.1-0.20210111080247-f2b63bfd6825 + github.com/cs3org/reva v1.5.1 github.com/gofrs/uuid v3.3.0+incompatible github.com/micro/cli/v2 v2.1.2 github.com/micro/go-micro/v2 v2.9.1 diff --git a/storage/go.sum b/storage/go.sum index ffdf9146be5..9e9a2462e6a 100644 --- a/storage/go.sum +++ b/storage/go.sum @@ -199,6 +199,8 @@ github.com/cs3org/reva v1.1.0/go.mod h1:fBzTrNuAKdQ62ybjpdu8nyhBin90/3/3s6DGQDCd github.com/cs3org/reva v1.2.2-0.20200924071957-e6676516e61e/go.mod h1:DOV5SjpOBKN+aWfOHLdA4KiLQkpyC786PQaXEdRAZ0M= github.com/cs3org/reva v1.4.1-0.20210111080247-f2b63bfd6825 h1:U6pAVGTjesstz+EXd8+YpIG1xwKH1ovOXdWrMCvnopw= github.com/cs3org/reva v1.4.1-0.20210111080247-f2b63bfd6825/go.mod h1:abC1Lo0ZKwkKloomTPZWunV/lUJvewkty1pI41zn2Ic= +github.com/cs3org/reva v1.5.1 h1:GebunCjhHfA3lFLXjQT+3jOUjEXUubk9sr3otOIDGac= +github.com/cs3org/reva v1.5.1/go.mod h1:abC1Lo0ZKwkKloomTPZWunV/lUJvewkty1pI41zn2Ic= github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= From e0b814724bdcb9420577ead8d4becd2e97ec22c0 Mon Sep 17 00:00:00 2001 From: Ilja Neumann Date: Thu, 21 Jan 2021 10:24:31 +0100 Subject: [PATCH 2/7] go mod tidy --- ocis/go.sum | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ocis/go.sum b/ocis/go.sum index a67c3209aca..fb712a9a283 100644 --- a/ocis/go.sum +++ b/ocis/go.sum @@ -265,6 +265,8 @@ github.com/cs3org/reva v0.0.2-0.20200115110931-4c7513415ec5/go.mod h1:Hk3eCcdhtv github.com/cs3org/reva v1.1.0/go.mod h1:fBzTrNuAKdQ62ybjpdu8nyhBin90/3/3s6DGQDCdBp4= github.com/cs3org/reva v1.4.1-0.20210111080247-f2b63bfd6825 h1:U6pAVGTjesstz+EXd8+YpIG1xwKH1ovOXdWrMCvnopw= github.com/cs3org/reva v1.4.1-0.20210111080247-f2b63bfd6825/go.mod h1:abC1Lo0ZKwkKloomTPZWunV/lUJvewkty1pI41zn2Ic= +github.com/cs3org/reva v1.5.1 h1:GebunCjhHfA3lFLXjQT+3jOUjEXUubk9sr3otOIDGac= +github.com/cs3org/reva v1.5.1/go.mod h1:abC1Lo0ZKwkKloomTPZWunV/lUJvewkty1pI41zn2Ic= github.com/cznic/b v0.0.0-20181122101859-a26611c4d92d h1:SwD98825d6bdB+pEuTxWOXiSjBrHdOl/UVp75eI7JT8= github.com/cznic/b v0.0.0-20181122101859-a26611c4d92d/go.mod h1:URriBxXwVq5ijiJ12C7iIZqlA69nTlI+LgI6/pwftG8= github.com/cznic/mathutil v0.0.0-20181122101859-297441e03548 h1:iwZdTE0PVqJCos1vaoKsclOGD3ADKpshg3SRtYBbwso= From 1bc902a0ab0badc6b8ad6622798730b69525dca4 Mon Sep 17 00:00:00 2001 From: Ilja Neumann Date: Thu, 21 Jan 2021 15:52:51 +0100 Subject: [PATCH 3/7] Adjust expected failures --- .../expected-failures-API-on-OCIS-storage.md | 6 ----- ...pected-failures-API-on-OWNCLOUD-storage.md | 4 ---- .../apiTrashbin-trashbinDelete.feature | 23 ------------------- 3 files changed, 33 deletions(-) diff --git a/tests/acceptance/expected-failures-API-on-OCIS-storage.md b/tests/acceptance/expected-failures-API-on-OCIS-storage.md index c2c9d57ff66..4f70ad82928 100644 --- a/tests/acceptance/expected-failures-API-on-OCIS-storage.md +++ b/tests/acceptance/expected-failures-API-on-OCIS-storage.md @@ -777,10 +777,6 @@ ### [empty trashbin does not work](https://github.com/owncloud/product/issues/254) -- [apiTrashbin/trashbinDelete.feature:31](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiTrashbin/trashbinDelete.feature#L31) -- [apiTrashbin/trashbinDelete.feature:32](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiTrashbin/trashbinDelete.feature#L32) -- [apiTrashbin/trashbinDelete.feature:33](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiTrashbin/trashbinDelete.feature#L33) -- [apiTrashbin/trashbinDelete.feature:34](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiTrashbin/trashbinDelete.feature#L34) - [apiTrashbin/trashbinDelete.feature:37](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiTrashbin/trashbinDelete.feature#L37) ### [href in trashbin PROPFIND response is wrong](https://github.com/owncloud/ocis/issues/1120) @@ -1223,8 +1219,6 @@ ### [cannot get share-types webdav property](https://github.com/owncloud/ocis/issues/567) -- [apiWebdavProperties2/getFileProperties.feature:135](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavProperties2/getFileProperties.feature#L135) -- [apiWebdavProperties2/getFileProperties.feature:136](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavProperties2/getFileProperties.feature#L136) - [apiWebdavProperties2/getFileProperties.feature:174](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavProperties2/getFileProperties.feature#L174) - [apiWebdavProperties2/getFileProperties.feature:175](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiWebdavProperties2/getFileProperties.feature#L175) diff --git a/tests/acceptance/expected-failures-API-on-OWNCLOUD-storage.md b/tests/acceptance/expected-failures-API-on-OWNCLOUD-storage.md index a9ee4f399f9..9b4aa7cffc3 100644 --- a/tests/acceptance/expected-failures-API-on-OWNCLOUD-storage.md +++ b/tests/acceptance/expected-failures-API-on-OWNCLOUD-storage.md @@ -876,10 +876,6 @@ User cannot create a folder named Share ### [delete from trashbin does not work](https://github.com/owncloud/ocis/issues/551) ### [deleting multiple elements concurrently will not delete all the items.](https://github.com/owncloud/product/issues/256) -- [apiTrashbin/trashbinDelete.feature:31](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiTrashbin/trashbinDelete.feature#L31) -- [apiTrashbin/trashbinDelete.feature:32](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiTrashbin/trashbinDelete.feature#L32) -- [apiTrashbin/trashbinDelete.feature:33](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiTrashbin/trashbinDelete.feature#L33) -- [apiTrashbin/trashbinDelete.feature:34](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiTrashbin/trashbinDelete.feature#L34) - [apiTrashbin/trashbinDelete.feature:37](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiTrashbin/trashbinDelete.feature#L37) - [apiTrashbin/trashbinDelete.feature:50](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiTrashbin/trashbinDelete.feature#L50) - [apiTrashbin/trashbinDelete.feature:67](https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiTrashbin/trashbinDelete.feature#L67) diff --git a/tests/acceptance/features/apiOcisSpecific/apiTrashbin-trashbinDelete.feature b/tests/acceptance/features/apiOcisSpecific/apiTrashbin-trashbinDelete.feature index ce45db8a092..680bcd8986b 100644 --- a/tests/acceptance/features/apiOcisSpecific/apiTrashbin-trashbinDelete.feature +++ b/tests/acceptance/features/apiOcisSpecific/apiTrashbin-trashbinDelete.feature @@ -13,29 +13,6 @@ Feature: files and folders can be deleted from the trashbin And user "Alice" has uploaded file with content "to delete" to "/PARENT/parent.txt" And user "Alice" has uploaded file with content "to delete" to "/PARENT/CHILD/child.txt" - @smokeTest - @issue-product-139 - @issue-product-178 - @issue-product-179 - Scenario Outline: Trashbin cannot be emptied - # after fixing all issues delete this Scenario and use the one from oC10 core - Given user "Alice" has uploaded file with content "file with comma" to "sample,0.txt" - And user "Alice" has uploaded file with content "file with comma" to "sample,1.txt" - And using DAV path - And user "Alice" has deleted file "" - And user "Alice" has deleted file "" - And as "Alice" file "" should exist in the trashbin - And as "Alice" file "" should exist in the trashbin - When user "Alice" empties the trashbin using the trashbin API - Then as "Alice" the file with original path "" should exist in the trashbin - And as "Alice" the file with original path "" should exist in the trashbin - Examples: - | dav-path | filename1 | filename2 | - | old | textfile0.txt | textfile1.txt | - | old | sample,0.txt | sample,1.txt | - | new | textfile0.txt | textfile1.txt | - | new | sample,0.txt | sample,1.txt | - @smokeTest @issue-ocis-reva-118 @issue-product-179 From 99f40c453a7c4da6219996058d1f7f7692fb0473 Mon Sep 17 00:00:00 2001 From: Ilja Neumann Date: Thu, 21 Jan 2021 19:09:04 +0100 Subject: [PATCH 4/7] Adjust expected failures --- .../acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md b/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md index 3249d0334c8..fa15b8247d4 100644 --- a/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md +++ b/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md @@ -392,9 +392,6 @@ Other free text and markdown formatting can be used elsewhere in the document if - [webUITrashbinDelete/trashbinDelete.feature:66](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L66) - [webUITrashbinDelete/trashbinDelete.feature:93](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L93) -### [Trashbin fails with unknown error when restoring](https://github.com/owncloud/product/issues/139) -- [webUITrashbinDelete/trashbinDelete.feature:114](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L114) - ### [Propfind response to trashbin endpoint is different in ocis](https://github.com/owncloud/product/issues/186) ### [restoring a file from "Deleted files" (trashbin) is not possible if the original folder does not exist any-more](https://github.com/owncloud/web/issues/1753) - [webUITrashbinRestore/trashbinRestore.feature:123](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinRestore/trashbinRestore.feature#L123) From 1fdb4cc6420e1d1da19442223f71077984fdd24e Mon Sep 17 00:00:00 2001 From: Ilja Neumann Date: Thu, 21 Jan 2021 20:12:42 +0100 Subject: [PATCH 5/7] changelog --- changelog/unreleased/update-reva-to-1.5.1.md | 76 ++++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 changelog/unreleased/update-reva-to-1.5.1.md diff --git a/changelog/unreleased/update-reva-to-1.5.1.md b/changelog/unreleased/update-reva-to-1.5.1.md new file mode 100644 index 00000000000..4ea6f224a8f --- /dev/null +++ b/changelog/unreleased/update-reva-to-1.5.1.md @@ -0,0 +1,76 @@ +Enhancement: Update reva to v1.5.1 + +Summary +------- + +* Fix #1401: Use the user in request for deciding the layout for non-home DAV requests +* Fix #1413: Re-include the '.git' dir in the Docker images to pass the version tag +* Fix #1399: Fix ocis trash-bin purge +* Enh #1397: Bump the Copyright date to 2021 +* Enh #1398: Support site authorization status in Mentix +* Enh #1393: Allow setting favorites, mtime and a temporary etag +* Enh #1403: Support remote cloud gathering metrics + +Details +------- + +* Bugfix #1401: Use the user in request for deciding the layout for non-home DAV requests + + For the incoming /dav/files/userID requests, we have different namespaces depending on + whether the request is for the logged-in user's namespace or not. Since in the storage drivers, + we specify the layout depending only on the user whose resources are to be accessed, this fails + when a user wants to access another user's namespace when the storage provider depends on the + logged in user's namespace. This PR fixes that. + + For example, consider the following case. The owncloud fs uses a layout {{substr 0 1 + .Id.OpaqueId}}/{{.Id.OpaqueId}}. The user einstein sends a request to access a resource + shared with him, say /dav/files/marie/abcd, which should be allowed. However, based on the + way we applied the layout, there's no way in which this can be translated to /m/marie/. + + https://github.com/cs3org/reva/pull/1401 + +* Bugfix #1413: Re-include the '.git' dir in the Docker images to pass the version tag + + And git SHA to the release tool. + + https://github.com/cs3org/reva/pull/1413 + +* Bugfix #1399: Fix ocis trash-bin purge + + Fixes the empty trash-bin functionality for ocis-storage + + https://github.com/owncloud/product/issues/254 + https://github.com/cs3org/reva/pull/1399 + +* Enhancement #1397: Bump the Copyright date to 2021 + + https://github.com/cs3org/reva/pull/1397 + +* Enhancement #1398: Support site authorization status in Mentix + + This enhancement adds support for a site authorization status to Mentix. This way, sites + registered via a web app can now be excluded until authorized manually by an administrator. + + Furthermore, Mentix now sets the scheme for Prometheus targets. This allows us to also support + monitoring of sites that do not support the default HTTPS scheme. + + https://github.com/cs3org/reva/pull/1398 + +* Enhancement #1393: Allow setting favorites, mtime and a temporary etag + + We now let the ocis driver persist favorites, set temporary etags and the mtime as arbitrary + metadata. + + https://github.com/owncloud/ocis/issues/567 + https://github.com/cs3org/reva/issues/1394 + https://github.com/cs3org/reva/pull/1393 + +* Enhancement #1403: Support remote cloud gathering metrics + + The current metrics package can only gather metrics either from json files. With this feature, + the metrics can be gathered polling the http endpoints exposed by the owncloud/nextcloud + sciencemesh apps. + + https://github.com/cs3org/reva/pull/1403 + +https://github.com/owncloud/ocis/pull/1372 From 4dde179449cc9a3e77985942adf189766fbf11d9 Mon Sep 17 00:00:00 2001 From: Phil Davis Date: Fri, 22 Jan 2021 11:35:49 +0545 Subject: [PATCH 6/7] Add 'failure' of trashbin bug demo scenario --- .../expected-failures-webUI-on-OWNCLOUD-storage.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md b/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md index fa15b8247d4..575d1129425 100644 --- a/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md +++ b/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md @@ -392,6 +392,13 @@ Other free text and markdown formatting can be used elsewhere in the document if - [webUITrashbinDelete/trashbinDelete.feature:66](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L66) - [webUITrashbinDelete/trashbinDelete.feature:93](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L93) +### [Trashbin fails with unknown error when restoring](https://github.com/owncloud/product/issues/139) + +This issue has been fixed. The following scenario was a bug-demonstration scenario for the problem. +So it is now "failing". The scenario will be removed from the webUI test suite in the next update. + +- [webUITrashbinDelete/trashbinDelete.feature:121](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L121) + ### [Propfind response to trashbin endpoint is different in ocis](https://github.com/owncloud/product/issues/186) ### [restoring a file from "Deleted files" (trashbin) is not possible if the original folder does not exist any-more](https://github.com/owncloud/web/issues/1753) - [webUITrashbinRestore/trashbinRestore.feature:123](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinRestore/trashbinRestore.feature#L123) From 9656013575f353f73d7073ff740b9af562e8ac52 Mon Sep 17 00:00:00 2001 From: Phil Davis Date: Fri, 22 Jan 2021 12:37:20 +0545 Subject: [PATCH 7/7] Bump WEB_COMMITID again for web PR 4652 --- .drone.env | 2 +- .../expected-failures-webUI-on-OWNCLOUD-storage.md | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/.drone.env b/.drone.env index 23edc16e835..798af17367f 100644 --- a/.drone.env +++ b/.drone.env @@ -3,5 +3,5 @@ CORE_COMMITID=ec99c594e90b83c8a3778834e31a5714df630ffc CORE_BRANCH=master # The test runner source for UI tests -WEB_COMMITID=a5f4dfab62aa036d7933f1286485e122e670b3ef +WEB_COMMITID=5945833ca594c16d33514da74b3d2eb64d3560fd WEB_BRANCH=master diff --git a/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md b/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md index 575d1129425..fa15b8247d4 100644 --- a/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md +++ b/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.md @@ -392,13 +392,6 @@ Other free text and markdown formatting can be used elsewhere in the document if - [webUITrashbinDelete/trashbinDelete.feature:66](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L66) - [webUITrashbinDelete/trashbinDelete.feature:93](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L93) -### [Trashbin fails with unknown error when restoring](https://github.com/owncloud/product/issues/139) - -This issue has been fixed. The following scenario was a bug-demonstration scenario for the problem. -So it is now "failing". The scenario will be removed from the webUI test suite in the next update. - -- [webUITrashbinDelete/trashbinDelete.feature:121](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinDelete/trashbinDelete.feature#L121) - ### [Propfind response to trashbin endpoint is different in ocis](https://github.com/owncloud/product/issues/186) ### [restoring a file from "Deleted files" (trashbin) is not possible if the original folder does not exist any-more](https://github.com/owncloud/web/issues/1753) - [webUITrashbinRestore/trashbinRestore.feature:123](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUITrashbinRestore/trashbinRestore.feature#L123)