Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display collaborator info in labels #4410

Merged
merged 13 commits into from
Dec 7, 2020
Merged

Display collaborator info in labels #4410

merged 13 commits into from
Dec 7, 2020

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Dec 2, 2020

Description

  • Use oc-tag component to display share info
  • Display public and private links
  • Refactor public links sidebar components

Requires release and update of ODS with new icons and fixed router-link variation of oc-tag owncloud/owncloud-design-system#975.

Screenshots

image

image

Test env

  • Drone

@LukasHirt LukasHirt self-assigned this Dec 2, 2020
@update-docs

This comment has been minimized.

@LukasHirt LukasHirt marked this pull request as ready for review December 6, 2020 16:26
@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Dec 6, 2020
@LukasHirt
Copy link
Collaborator Author

Commit history is rather chaotic for this one but still keeping it for now in case it would be at least a bit helpful for the review. After the PR is approved I'll squash it.

changelog/unreleased/share-info-labels Outdated Show resolved Hide resolved
changelog/unreleased/visible-links Outdated Show resolved Hide resolved
Lukas Hirt and others added 5 commits December 7, 2020 12:28
@LukasHirt
Copy link
Collaborator Author

LukasHirt commented Dec 7, 2020

With updated ODS, node version 11 was not compatible. As we do not have version 12 in owncloud-ci, I switched here to the one from webhippie /cc @micbar

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@LukasHirt LukasHirt merged commit 5faa4df into master Dec 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the info-labels branch December 7, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants