From 4e9aa0b6e61d31bc2e904f8e9819862f9f04d59a Mon Sep 17 00:00:00 2001 From: Jannik Stehle <50302941+JammingBen@users.noreply.github.com> Date: Wed, 4 May 2022 15:25:03 +0200 Subject: [PATCH] [full-ci] Remove the upload progress bar and its related states (#6825) Remove the upload progress bar and its related states Co-authored-by: Saw-jan --- ...hancement-remove-upload-progress-component | 6 + packages/web-app-files/src/App.vue | 4 - .../src/components/Upload/DetailsWidget.vue | 50 ----- .../src/components/Upload/ProgressBar.vue | 177 ------------------ .../useFileListHeaderPosition.ts | 5 +- packages/web-app-files/src/store/getters.js | 3 - packages/web-app-files/src/store/state.js | 2 - packages/web-app-files/src/views/Personal.vue | 7 - .../web-app-files/src/views/PublicFiles.vue | 8 - .../src/views/spaces/Project.vue | 8 - .../tests/unit/components/Search/List.spec.js | 1 - .../components/Upload/DetailsWidget.spec.js | 59 ------ .../components/Upload/ProgressBar.spec.js | 167 ----------------- .../__snapshots__/ProgressBar.spec.js.snap | 49 ----- .../tests/unit/components/components.setup.js | 2 - .../fileListHeaderPosition/spec/index.ts | 20 -- .../useFileListHeaderPosition.spec.ts | 16 -- .../tests/unit/views/Personal.spec.js | 3 +- .../tests/unit/views/spaces/Project.spec.js | 3 +- .../spaces/__snapshots__/Project.spec.js.snap | 2 - .../tests/unit/views/views.setup.js | 2 - .../tests/unit/views/views.shared.ts | 1 - .../web-runtime/src/container/bootstrap.ts | 2 +- ...-failures-with-oc10-server-oauth2-login.md | 4 +- .../federationSharing.feature | 3 +- .../federationSharing.feature | 3 +- tests/acceptance/pageObjects/personalPage.js | 4 +- 27 files changed, 17 insertions(+), 594 deletions(-) create mode 100644 changelog/unreleased/enhancement-remove-upload-progress-component delete mode 100644 packages/web-app-files/src/components/Upload/DetailsWidget.vue delete mode 100644 packages/web-app-files/src/components/Upload/ProgressBar.vue delete mode 100644 packages/web-app-files/tests/unit/components/Upload/DetailsWidget.spec.js delete mode 100644 packages/web-app-files/tests/unit/components/Upload/ProgressBar.spec.js delete mode 100644 packages/web-app-files/tests/unit/components/Upload/__snapshots__/ProgressBar.spec.js.snap diff --git a/changelog/unreleased/enhancement-remove-upload-progress-component b/changelog/unreleased/enhancement-remove-upload-progress-component new file mode 100644 index 00000000000..db58b79e943 --- /dev/null +++ b/changelog/unreleased/enhancement-remove-upload-progress-component @@ -0,0 +1,6 @@ +Enhancement: Remove the upload progress component + +We've removed the upload progress component because the implementation of Uppy made it obsolete. + +https://github.com/owncloud/web/pull/6825 +https://github.com/owncloud/web/issues/6819 diff --git a/packages/web-app-files/src/App.vue b/packages/web-app-files/src/App.vue index b9e1d445c57..3296ede5db1 100644 --- a/packages/web-app-files/src/App.vue +++ b/packages/web-app-files/src/App.vue @@ -104,8 +104,4 @@ main { grid-area: main; z-index: 0; } - -#files-upload-progress { - grid-area: upload; -} diff --git a/packages/web-app-files/src/components/Upload/DetailsWidget.vue b/packages/web-app-files/src/components/Upload/DetailsWidget.vue deleted file mode 100644 index 426fef9539b..00000000000 --- a/packages/web-app-files/src/components/Upload/DetailsWidget.vue +++ /dev/null @@ -1,50 +0,0 @@ - - diff --git a/packages/web-app-files/src/components/Upload/ProgressBar.vue b/packages/web-app-files/src/components/Upload/ProgressBar.vue deleted file mode 100644 index d2d9129d785..00000000000 --- a/packages/web-app-files/src/components/Upload/ProgressBar.vue +++ /dev/null @@ -1,177 +0,0 @@ - - - - - - diff --git a/packages/web-app-files/src/composables/fileListHeaderPosition/useFileListHeaderPosition.ts b/packages/web-app-files/src/composables/fileListHeaderPosition/useFileListHeaderPosition.ts index 01813592db8..25a732fae2a 100644 --- a/packages/web-app-files/src/composables/fileListHeaderPosition/useFileListHeaderPosition.ts +++ b/packages/web-app-files/src/composables/fileListHeaderPosition/useFileListHeaderPosition.ts @@ -1,8 +1,6 @@ -import { ref, nextTick, onMounted, Ref, watch } from '@vue/composition-api' -import { useStore } from 'web-pkg/src/composables/store' +import { ref, nextTick, onMounted, Ref } from '@vue/composition-api' export const useFileListHeaderPosition = (): { y: Ref; refresh: () => void } => { - const store = useStore() const y = ref(0) const refresh = async (): Promise => { await nextTick() @@ -18,7 +16,6 @@ export const useFileListHeaderPosition = (): { y: Ref; refresh: () => void } => window.onresize = refresh onMounted(refresh) - watch(() => store.getters['Files/inProgress'].length > 0, refresh) return { y, refresh } } diff --git a/packages/web-app-files/src/store/getters.js b/packages/web-app-files/src/store/getters.js index bbe323ba063..3b48a020173 100644 --- a/packages/web-app-files/src/store/getters.js +++ b/packages/web-app-files/src/store/getters.js @@ -1,9 +1,6 @@ import { ShareTypes } from '../helpers/share' export default { - inProgress: (state) => { - return state.inProgress - }, selectedFiles: (state, getters) => { return getters.filesAll.filter((f) => state.selectedIds.includes(f.id)) }, diff --git a/packages/web-app-files/src/store/state.js b/packages/web-app-files/src/store/state.js index 7e587852dfe..7bba9e74451 100644 --- a/packages/web-app-files/src/store/state.js +++ b/packages/web-app-files/src/store/state.js @@ -3,8 +3,6 @@ export default { files: [], filesSearched: null, selectedIds: [], - inProgress: [], - shareOpen: null, versions: [], spaces: [], diff --git a/packages/web-app-files/src/views/Personal.vue b/packages/web-app-files/src/views/Personal.vue index c2f91899808..b55bfb21e08 100644 --- a/packages/web-app-files/src/views/Personal.vue +++ b/packages/web-app-files/src/views/Personal.vue @@ -11,7 +11,6 @@