diff --git a/changelog/unreleased/enhancement-remove-settings-icon-from-search-bar b/changelog/unreleased/enhancement-remove-settings-icon-from-search-bar new file mode 100644 index 00000000000..17757dcb67b --- /dev/null +++ b/changelog/unreleased/enhancement-remove-settings-icon-from-search-bar @@ -0,0 +1,6 @@ +Enhancement: Remove settings icon from searchbar + +We removed the settings icon from the searchbar. + +https://github.com/owncloud/web/pull/9858 +https://github.com/owncloud/web/issues/9664 diff --git a/packages/design-system/src/components/OcSearchBar/OcSearchBar.spec.ts b/packages/design-system/src/components/OcSearchBar/OcSearchBar.spec.ts index fc5c5d951d6..777bb82e22a 100644 --- a/packages/design-system/src/components/OcSearchBar/OcSearchBar.spec.ts +++ b/packages/design-system/src/components/OcSearchBar/OcSearchBar.spec.ts @@ -4,7 +4,6 @@ import OcSearchBar from './OcSearchBar.vue' describe('OcSearchBar', () => { const selectors = { searchButton: '.oc-search-button', - advancedSearchButton: '.oc-advanced-search', searchInput: '.oc-search-input', searchButtonWrapper: '.oc-search-button-wrapper', searchClearButton: '.oc-search-clear' @@ -42,10 +41,6 @@ describe('OcSearchBar', () => { describe('icon prop', () => { describe('when icon prop is not false', () => { const wrapper = getWrapper({ icon: 'mdi-icon' }) - it('should add icon class to search input', () => { - const searchInput = wrapper.find(selectors.searchInput) - expect(searchInput.attributes('class')).toContain('oc-search-input-icon') - }) it('should render icon', () => { const iconStub = wrapper.find('oc-icon-stub[name="mdi-icon"]') expect(iconStub.exists()).toBeTruthy() @@ -185,21 +180,6 @@ describe('OcSearchBar', () => { expect(wrapper.emitted('search')).toBeFalsy() }) }) - describe('advanced search button', () => { - it('should be visible', () => { - const wrapper = getWrapper() - expect(wrapper.find(selectors.advancedSearchButton).exists()).toBeTruthy() - }) - it('should not be visible if disabled', () => { - const wrapper = getWrapper({ showAdvancedSearchButton: false }) - expect(wrapper.find(selectors.advancedSearchButton).exists()).toBeFalsy() - }) - it('should trigger the "advancedSearch"-event on click', async () => { - const wrapper = getWrapper() - await wrapper.find(selectors.advancedSearchButton).trigger('click') - expect(wrapper.emitted('advancedSearch').length).toBeGreaterThan(0) - }) - }) }) function getWrapper(props = {}) { diff --git a/packages/design-system/src/components/OcSearchBar/OcSearchBar.vue b/packages/design-system/src/components/OcSearchBar/OcSearchBar.vue index e0caef145e6..ca4f66c545a 100644 --- a/packages/design-system/src/components/OcSearchBar/OcSearchBar.vue +++ b/packages/design-system/src/components/OcSearchBar/OcSearchBar.vue @@ -6,14 +6,6 @@ :class="{ 'oc-search-small': small }" >