From ceaf345312f3aa3b99a68971345748fef44cfaaa Mon Sep 17 00:00:00 2001 From: amrita Date: Mon, 17 Oct 2022 12:00:04 +0545 Subject: [PATCH] Skip tests on ocis --- ...-failures-with-oc10-server-oauth2-login.md | 2 +- ...-failures-with-ocis-server-ocis-storage.md | 21 ------------------- .../restrictReSharing.feature | 7 +++---- .../restrictSharing.feature | 9 ++++---- .../acceptShares.feature | 12 +++++------ .../shareWithGroups.feature | 4 ++-- .../shareWithUsers.feature | 3 ++- 7 files changed, 19 insertions(+), 39 deletions(-) diff --git a/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md b/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md index 43998f42971..35c6545f8bc 100644 --- a/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md +++ b/tests/acceptance/expected-failures-with-oc10-server-oauth2-login.md @@ -34,7 +34,7 @@ Other free text and markdown formatting can be used elsewhere in the document if - [webUISharingExternal/federationSharing.feature:166](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingExternal/federationSharing.feature#L166) ### [reshared share that is shared with a group the sharer is part of shows twice on "Share with me" page](https://github.com/owncloud/web/issues/2512) -- [webUISharingAcceptShares/acceptShares.feature:31](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L31) +- [webUISharingAcceptShares/acceptShares.feature:33](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L33) ### [empty subfolder inside a folder to be uploaded is not created on the server](https://github.com/owncloud/web/issues/6348) - [webUIUpload/upload.feature:42](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L42) diff --git a/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md b/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md index 1ed02bf233b..d30878b08e4 100644 --- a/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md +++ b/tests/acceptance/expected-failures-with-ocis-server-ocis-storage.md @@ -37,19 +37,6 @@ Other free text and markdown formatting can be used elsewhere in the document if - [webUIFilesCopy/copyPrivateLinks.feature:20](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesCopy/copyPrivateLinks.feature#L20) - [webUIFilesCopy/copyPrivateLinks.feature:21](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesCopy/copyPrivateLinks.feature#L21) -### [No occ command in ocis](https://github.com/owncloud/ocis/issues/1317) -- [webUIRestrictSharing/restrictReSharing.feature:23](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIRestrictSharing/restrictReSharing.feature#L23) -- [webUIRestrictSharing/restrictReSharing.feature:42](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIRestrictSharing/restrictReSharing.feature#L42) -- [webUIRestrictSharing/restrictSharing.feature:31](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature#L31) -- [webUIRestrictSharing/restrictSharing.feature:40](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature#L40) -- [webUIRestrictSharing/restrictSharing.feature:56](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature#L56) -- [webUISharingInternalUsersBlacklisted/shareWithUsers.feature:16](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsersBlacklisted/shareWithUsers.feature#L16) -- [webUISharingInternalUsersBlacklisted/shareWithUsers.feature:34](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsersBlacklisted/shareWithUsers.feature#L34) -- [webUISharingInternalUsersBlacklisted/shareWithUsers.feature:52](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsersBlacklisted/shareWithUsers.feature#L52) -- [webUISharingInternalUsersBlacklisted/shareWithUsers.feature:70](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsersBlacklisted/shareWithUsers.feature#L70) -- [webUISharingInternalUsersBlacklisted/shareWithUsers.feature:82](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsersBlacklisted/shareWithUsers.feature#L82) -- [webUISharingInternalGroups/shareWithGroups.feature:202](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature#L202) - ### [Cannot create users with special characters](https://github.com/owncloud/ocis/issues/1417) - [webUISharingAutocompletion/shareAutocompletionSpecialChars.feature:37](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAutocompletion/shareAutocompletionSpecialChars.feature#L37) - [webUISharingAutocompletion/shareAutocompletionSpecialChars.feature:38](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAutocompletion/shareAutocompletionSpecialChars.feature#L38) @@ -139,14 +126,6 @@ Other free text and markdown formatting can be used elsewhere in the document if - [webUISharingExternal/federationSharing.feature:38](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingExternal/federationSharing.feature#L38) - [webUISharingExternal/federationSharing.feature:166](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingExternal/federationSharing.feature#L166) -### [reshared share that is shared with a group the sharer is part of shows twice on "Share with me" page](https://github.com/owncloud/web/issues/2512) -- [webUISharingAcceptShares/acceptShares.feature:31](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L31) - -### [[oCIS] Received share cannot be deleted/unshared if not shared with full permissions](https://github.com/owncloud/web/issues/5531) -- [webUISharingAcceptShares/acceptShares.feature:49](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L49) -- [webUISharingAcceptShares/acceptShares.feature:161](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L161) -- [webUISharingAcceptShares/acceptShares.feature:200](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L200) - ### [not possible to overwrite a received shared file](https://github.com/owncloud/ocis/issues/2267) - [webUISharingInternalGroups/shareWithGroups.feature:79](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature#L79) - [webUISharingInternalUsers/shareWithUsers.feature:55](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature#L55) diff --git a/tests/acceptance/features/webUIRestrictSharing/restrictReSharing.feature b/tests/acceptance/features/webUIRestrictSharing/restrictReSharing.feature index 0c4c587970d..7ef30d91a7f 100644 --- a/tests/acceptance/features/webUIRestrictSharing/restrictReSharing.feature +++ b/tests/acceptance/features/webUIRestrictSharing/restrictReSharing.feature @@ -1,4 +1,6 @@ -@issue-ocis-1317 +@issue-ocis-1317 @skipOnOCIS @issue-6896 +# this scenario is skipped on ocis because it opens share folder which in not possible in OCIS +# but it works for OC10 see issue https://github.com/owncloud/web/issues/6896 for more detail Feature: restrict resharing As an admin I want to be able to forbid the sharing of a received share globally @@ -35,9 +37,6 @@ Feature: restrict resharing When the user browses to the favorites page Then the user should not be able to share folder "Shares/simple-folder" using the webUI - - - @smokeTest Scenario: disable resharing and check if the received resource from group share can be reshared Given the setting "shareapi_allow_resharing" of app "core" has been set to "no" in the server diff --git a/tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature b/tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature index 95fa10f30e2..37508c2fcc8 100644 --- a/tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature +++ b/tests/acceptance/features/webUIRestrictSharing/restrictSharing.feature @@ -1,4 +1,4 @@ -@issue-ocis-1317 +@issue-ocis-1317 @skipOnOCIS Feature: restrict Sharing As an admin I want to be able to restrict the sharing function @@ -29,24 +29,25 @@ Feature: restrict Sharing @smokeTest Scenario: Restrict users to only share with users in their groups +# shares-only-with-groups-members configuration is not available yet in the oCIS webUI Given the setting "shareapi_only_share_with_group_members" of app "core" has been set to "yes" in the server When the user opens the share dialog for folder "simple-folder" using the webUI - And the user types "Ali" in the share-with-field Then "user" "Alice Hansen" should be listed in the autocomplete list on the webUI But "user" "Alison Cooper" should not be listed in the autocomplete list on the webUI @smokeTest Scenario: Restrict users to only share with groups they are member of +# shares-only-with-groups-members configuration is not available yet in the oCIS webUI Given the setting "shareapi_only_share_with_membership_groups" of app "core" has been set to "yes" in the server When the user opens the share dialog for folder "simple-folder" using the webUI - And the user types "grp" in the share-with-field Then "group" "grp1" should be listed in the autocomplete list on the webUI But "group" "grp2" should not be listed in the autocomplete list on the webUI Scenario: Do not restrict users to only share with groups they are member of +# shares-only-with-groups-members configuration is not available yet in the oCIS webUI Given the setting "shareapi_only_share_with_membership_groups" of app "core" has been set to "no" in the server When the user shares folder "simple-folder" with group "grp2" as "Viewer" using the webUI And user "Carol" accepts the share "Shares/simple-folder" offered by user "Brian" using the sharing API in the server @@ -54,9 +55,9 @@ Feature: restrict Sharing @smokeTest Scenario: Forbid sharing with groups +# allow-shares-with-groups-members configuration is not available yet in the oCIS webUI Given the setting "shareapi_allow_group_sharing" of app "core" has been set to "no" in the server When the user opens the share dialog for folder "simple-folder" using the webUI - And the user types "grp" in the share-with-field Then "group" "grp1" should not be listed in the autocomplete list on the webUI And "group" "grp2" should not be listed in the autocomplete list on the webUI diff --git a/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature b/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature index 0165e497342..83a475471b2 100644 --- a/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature +++ b/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature @@ -1,3 +1,5 @@ +# some scenario is skipped on ocis because it opens share folder which in not possible in OCIS +# but it works for OC10 see issue https://github.com/owncloud/web/issues/6896 for more detail Feature: accept/decline shares coming from internal users As a user I want to have control of which received shares I accept @@ -27,7 +29,7 @@ Feature: accept/decline shares coming from internal users When the user browses to the files page Then folder "/Shares" should not be listed on the webUI - @issue-2512 @issue-4102 + @issue-2512 @issue-4102 @skipOnOCIS Scenario: reshare a share that you received to a group that you are member of Given these groups have been created in the server: | groupname | @@ -45,7 +47,7 @@ Feature: accept/decline shares coming from internal users And folder "simple-folder" shared by "Brian Murphy" should not be listed on the webUI And folder "simple-folder" should not be listed on the webUI - @issue-4102 @issue-5531 + @issue-4102 @issue-5531 @skipOnOCIS Scenario: unshare accepted shares from "All files" page Given these groups have been created in the server: | groupname | @@ -93,8 +95,6 @@ Feature: accept/decline shares coming from internal users - - Scenario: receive shares with same name from different users Given user "Carol" has been created with default attributes and without skeleton files in the server And user "Carol" has created file "lorem.txt" in the server @@ -157,7 +157,7 @@ Feature: accept/decline shares coming from internal users Then file "lorem.txt" should be listed on the webUI And file "testimage.jpg" should not be listed on the webUI - @issue-4102 @issue-5531 + @issue-4102 @issue-5531 @skipOnOCIS Scenario: delete an accepted share Given user "Alice" has created file "lorem.txt" in the server And user "Alice" has uploaded file "testavatar.jpg" to "testimage.jpg" in the server @@ -196,7 +196,7 @@ Feature: accept/decline shares coming from internal users And file "lorem.txt" shared by "Alice Hansen" should be in "Declined" state on the webUI And folder "simple-folder" shared by "Alice Hansen" should be in "Declined" state on the webUI - @issue-4102 @issue-5531 + @issue-4102 @issue-5531 @skipOnOCIS Scenario: shared file status is changed to declined when user deletes the file Given user "Alice" has created file "lorem.txt" in the server And user "Alice" has shared file "lorem.txt" with user "Brian" in the server diff --git a/tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature b/tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature index 2c9def14489..ccade2f03f6 100644 --- a/tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature +++ b/tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature @@ -198,15 +198,15 @@ Feature: Sharing files and folders with internal groups And as "Brian" file "/Shares/lorem.txt" should not exist in the server But as "Carol" file "/Shares/lorem.txt" should exist in the server - @issue-ocis-1317 + @issue-ocis-1317 @skipOnOCIS Scenario: Auto-completion for a group that is excluded from receiving shares Given group "system-group" has been created in the server And user "Alice" has created folder "simple-folder" in the server +# exclude-groups-from-sharing configuration is not available yet in the oCIS webUI And the administrator has excluded group "system-group" from receiving shares in the server When the user re-logs in as "Alice" using the webUI And the user browses to the files page And the user opens the share dialog for folder "simple-folder" using the webUI - And the user types "system-group" in the share-with-field Then the autocomplete list should not be displayed on the webUI diff --git a/tests/acceptance/features/webUISharingInternalUsersBlacklisted/shareWithUsers.feature b/tests/acceptance/features/webUISharingInternalUsersBlacklisted/shareWithUsers.feature index dbf0b438b7b..7a4ce58355b 100644 --- a/tests/acceptance/features/webUISharingInternalUsersBlacklisted/shareWithUsers.feature +++ b/tests/acceptance/features/webUISharingInternalUsersBlacklisted/shareWithUsers.feature @@ -1,4 +1,5 @@ -@issue-ocis-1317 +@issue-ocis-1317 @skipOnOCIS +# exclude-groups-from-sharing configuration is not available yet in the oCIS webUI Feature: Sharing files and folders with internal users As a user I want to share files and folders with other users