Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gap size in "copy instead" modal is not aligned with other modals #10208

Closed
kulmann opened this issue Dec 19, 2023 · 0 comments · Fixed by #10212
Closed

Gap size in "copy instead" modal is not aligned with other modals #10208

kulmann opened this issue Dec 19, 2023 · 0 comments · Fixed by #10212
Assignees
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented Dec 19, 2023

Describe the bug

When cutting files/folders and then trying to paste them into a different space, we show a modal that informs the user about moving files not being possible and asking if the user wants to copy the files instead.
The gap size between a: header separator line and the first block of text and b: last block of text and the footer row with the buttons is bigger than usual and looks off.

Steps to reproduce

  1. Select files in your personal space
  2. Use batch action "cut" (or cmd+x keyboard shortcut)
  3. Navigate into a different space
  4. Use "paste" action (or cmd+v keyboard shortcut)

Expected behavior

Gap sizes in modal look like in every other modal.

Actual behavior

Gap sizes are not aligned with other modals, see Screenshot.

Screenshots

Screenshot 2023-12-19 at 06 41 48 Screenshot 2023-12-19 at 06 45 41

Additional context

The "copy instead" modal holds two <p> tags, which bring a margin of 14px top and bottom. Those margins (top on first <p> and bottom on last <p>) are unnecessary.

@kulmann kulmann added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Dec 19, 2023
@JammingBen JammingBen self-assigned this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants