Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch delete on shared with me page must decline all shares #3101

Closed
PVince81 opened this issue Feb 27, 2020 · 0 comments · Fixed by #5374
Closed

Batch delete on shared with me page must decline all shares #3101

PVince81 opened this issue Feb 27, 2020 · 0 comments · Fixed by #5374
Labels
Type:Bug Something isn't working

Comments

@PVince81
Copy link
Contributor

Steps

  1. Create two users "user1" and "user2"
  2. Login as "user1"
  3. Create three folders "accepted", "pending", "rejected"
  4. Share all three with "user2"
  5. Login as "user2"
  6. Go to the "shared with me" page. All three shares appear pending.
  7. For "accepted" click on "Accept"
  8. For "rejected" click on "Decline"
  9. Refresh the page
  10. Select all three shares with the top checkbox
  11. Click "Delete" on the top bar to batch delete

Expected result

All shares are now declined

Actual result

Errors occur because the wrong request is sent: a Webdav DELETE is sent instead of an OCS Share API call for declining. This is because the batch delete button uses the code path for file deletion.

Need to branch the code path to use the share API when batch declining.

Version

master (actually found on #3049)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant