Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass view mode to /app/open #5903

Closed
ishank011 opened this issue Oct 14, 2021 · 8 comments
Closed

Pass view mode to /app/open #5903

ishank011 opened this issue Oct 14, 2021 · 8 comments

Comments

@ishank011
Copy link

No description provided.

@pascalwengerter
Copy link
Contributor

Could someone share some insights on what the expected format/possible parameters on the backend are / what we should pass there? @ishank011 @wkloucek

@wkloucek
Copy link
Contributor

Could someone share some insights on what the expected format/possible parameters on the backend are / what we should pass there? @ishank011 @wkloucek

I'm sorry, but I still need to point you to a draft PR https://github.com/owncloud/ocis/pull/2580/files . I just wrote a section about query parameters of the /app/open endpoint

@pascalwengerter
Copy link
Contributor

Could someone share some insights on what the expected format/possible parameters on the backend are / what we should pass there? @ishank011 @wkloucek

I'm sorry, but I still need to point you to a draft PR https://github.com/owncloud/ocis/pull/2580/files . I just wrote a section about query parameters of the /app/open endpoint

Enough to at least get started, thanks!

@pascalwengerter
Copy link
Contributor

Needs concepting by @tbsbdr on how to handle the different view-modes from a UI/UX perspective - should we offer them on a per-app level on a sub-dropdown (as e.g. Open OpenOffice ... and then display in view mode, in edit mode, in read mode)

@pascalwengerter
Copy link
Contributor

@fschade we talked about this one, I'll assign you

@tbsbdr
Copy link
Contributor

tbsbdr commented Nov 5, 2021

Hey @ishank011 I guess the usecase is the following:
As a user who just wants to sneak peek into files I want to be sure that I don't accidentally modify them.
Is this correct?

@ishank011
Copy link
Author

Hi @tbsbdr, apologies for the late response.

Yes, that would be the use case. For users having a conjunction of permissions on a file, they should be able to open it in any specific view mode. The /app/open endpoint accepts a view_mode=(view|read|write) query parameter for this

@JammingBen
Copy link
Collaborator

This has been implemented via #9879, hence closing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants