Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing role of a public link with expiry date doesn't work #6858

Closed
SwikritiT opened this issue May 3, 2022 · 7 comments · Fixed by #6867
Closed

Changing role of a public link with expiry date doesn't work #6858

SwikritiT opened this issue May 3, 2022 · 7 comments · Fixed by #6867
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@SwikritiT
Copy link
Contributor

SwikritiT commented May 3, 2022

Steps to reproduce

  1. Create a public link of a resource with an expiry date
  2. Now try to change the role of the previously created public link

Expected behaviour

The role should be changed with the message Link was updated successfully

Actual behavior

Two messages Failed to update link and Link was updated successfully are displayed but the role is not updated. The behavior is the same for both backends

publiclink.mp4
@SwikritiT SwikritiT added the Type:Bug Something isn't working label May 3, 2022
@SwikritiT
Copy link
Contributor Author

The test in this PR is failing because of this issue: #6557
link to build: https://drone.owncloud.com/owncloud/web/25145/11/18

@pascalwengerter
Copy link
Contributor

This issue isn't about a problem in master but about something blocking your PR, or am I reading this wrong?

@SwikritiT
Copy link
Contributor Author

This issue isn't about a problem in master but about something blocking your PR, or am I reading this wrong?

It is an issue in master. In my PR I was writing new tests for changing the role and this was caught. I can reproduce it in my local setup as well.

@pascalwengerter
Copy link
Contributor

I can't from the steps you outlined above, also we do have acceptance tests on master that pass for this behaviour.

Could you narrow it down whether it Is it related to the link being password-protected or having an expiry date? A freshly created public link can have role changes without errrors

@SwikritiT
Copy link
Contributor Author

I can't from the steps you outlined above, also we do have acceptance tests on master that pass for this behaviour.

Could you narrow it down whether it Is it related to the link being password-protected or having an expiry date? A freshly created public link can have role changes without errrors

It's because of the expiry date. Can you check again with the expiry date?

@SwikritiT SwikritiT changed the title Changing role of a public link doesn't work Changing role of a public link doesn't work with expiry date May 3, 2022
@SwikritiT SwikritiT changed the title Changing role of a public link doesn't work with expiry date Changing role of a public link with expiry date doesn't work May 3, 2022
@pascalwengerter
Copy link
Contributor

Thank you for raising it and further investigation, I'll take care of this issue

@pascalwengerter pascalwengerter self-assigned this May 3, 2022
@ScharfViktor ScharfViktor added the Priority:p2-high Escalation, on top of current planning, release blocker label May 3, 2022
@ScharfViktor
Copy link
Contributor

I reproduced it. Description is here: #6865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants