You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
oxc-project/oxc#7175 demonstrates that it's easy to confuse a function which is the property value of an object expression with an object method. i.e. to conflate these 2:
obj={foo(){}};obj={foo: function(){}};
We could avoid this confusing by changing ObjectPropertyKind to have separate variants for methods, getters and setters.
Current:
pubenumObjectPropertyKind<'a>{// This variant can be either a property or a methodObjectProperty(Box<'a,ObjectProperty<'a>>),SpreadProperty(Box<'a,SpreadElement<'a>>),}
Let's see how @ottomated's work progresses, but hopefully it'll make it easier for us to shape our Rust AST however we choose, while still having an ESTree-compatible AST on JS side.
oxc-project/oxc#7175 demonstrates that it's easy to confuse a function which is the property value of an object expression with an object method. i.e. to conflate these 2:
We could avoid this confusing by changing
ObjectPropertyKind
to have separate variants for methods, getters and setters.Current:
Proposed:
The text was updated successfully, but these errors were encountered: