You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Many AstBuilder methods take an IntoIn<'a, Atom<'a>> where an Atom is required. This was intended to give flexibility, but it makes it too easy to accidentally copy existing Atoms and make duplicate copies of them in arena, when could just use the original Atom.
Make AstBuilder methods just take Atom<'a>, and make user generate the Atom themselves. Usually they'll find they don't have to, because they have an existing Atom already.
The text was updated successfully, but these errors were encountered:
Many
AstBuilder
methods take anIntoIn<'a, Atom<'a>>
where anAtom
is required. This was intended to give flexibility, but it makes it too easy to accidentally copy existingAtom
s and make duplicate copies of them in arena, when could just use the originalAtom
.e.g. oxc-project/oxc#7969
Make
AstBuilder
methods just takeAtom<'a>
, and make user generate theAtom
themselves. Usually they'll find they don't have to, because they have an existingAtom
already.The text was updated successfully, but these errors were encountered: