Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 init options binding #19

Merged
merged 6 commits into from
Dec 12, 2023
Merged

feat: 🎸 init options binding #19

merged 6 commits into from
Dec 12, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

No description provided.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 10, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #19 will not alter performance

⚠️ No base runs were found

Falling back to comparing IWANABETHATGUY:feat/options-binding (65679c2) with main (fe0d2c3)

Summary

✅ 2 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review December 10, 2023 14:39
Boshen
Boshen reviewed Dec 11, 2023
View reviewed changes
napi/src/options.rs Outdated Show resolved Hide resolved
napi/src/options.rs Outdated Show resolved Hide resolved
napi/src/options.rs Show resolved Hide resolved
napi/src/options.rs Show resolved Hide resolved
Boshen
Boshen reviewed Dec 11, 2023
View reviewed changes
napi/ts.ts Outdated Show resolved Hide resolved
@Boshen Boshen enabled auto-merge (squash) December 12, 2023 04:53
@Boshen Boshen merged commit 276390d into oxc-project:main Dec 12, 2023
16 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the feat/options-binding branch December 12, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IWANABETHATGUY @Boshen