Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better way of telegraphing which files are processed by oxc_ast_codegen #4700

Closed
rzvxa opened this issue Aug 6, 2024 · 1 comment
Closed
Labels
C-enhancement Category - New feature or request

Comments

@rzvxa
Copy link
Contributor

rzvxa commented Aug 6, 2024

Copied from #4696 (comment)

Great to have these types included in schema.
Personally I wouldn't have split the types into a separate file. Is the rationale for that to give the codegen less code to chew through looking for items with an #[ast] attr? If so, I wouldn't worry too much about that - the file is not so large, and it's no big deal if the codegen isn't quite as quick as it could be.

I intentionally panic on unrelated items in the source read by codegen. It isn't for performance purposes, I don't care for performance in the codegen.

It lowers the clutter in the rust definition files, I would even suggest going as far as changing the file extension to something like XXX.d.rs. Otherwise, we have no way of reasoning about what is and isn't included in the codegen(unless you read the source code).

@rzvxa rzvxa added the C-enhancement Category - New feature or request label Aug 6, 2024
@rzvxa
Copy link
Contributor Author

rzvxa commented Aug 6, 2024

Close in favor of oxc-project/backlog#124 , If we find that approach bad for compile times we can reopen this.

@rzvxa rzvxa closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category - New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant