Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to turn on oxlint --import-plugin in vscode extension #6416

Closed
pumano opened this issue Oct 10, 2024 · 10 comments · Fixed by #6088
Closed

Possibility to turn on oxlint --import-plugin in vscode extension #6416

pumano opened this issue Oct 10, 2024 · 10 comments · Fixed by #6088
Labels
A-linter Area - Linter C-enhancement Category - New feature or request

Comments

@pumano
Copy link
Contributor

pumano commented Oct 10, 2024

Currently oxc vscode extension not show error messages for import plugin, but for example rules like import/no-cycle is very useful (while in eslint it's time intensive operation) but not working out of the box and not possible to turn on via config.

@pumano pumano added the C-enhancement Category - New feature or request label Oct 10, 2024
@DonIsaac
Copy link
Contributor

Will be added in #6088

@DonIsaac DonIsaac linked a pull request Oct 10, 2024 that will close this issue
@DonIsaac DonIsaac added the A-linter Area - Linter label Oct 10, 2024
@pumano
Copy link
Contributor Author

pumano commented Oct 10, 2024

@DonIsaac can't wait!) Very important to me feature because I want to be early adopter as possible because my entire team will get benefits from 1 sec linting!

@DonIsaac
Copy link
Contributor

Glad you're exited! This will be available in the v1 release.

@pumano
Copy link
Contributor Author

pumano commented Oct 14, 2024

@DonIsaac I build from source today vscode extension, fresh oxlint, oxlint suport plugins in config, when I add "import" It Works perfectly, but vscode extension not show "import" plugin warns / errors

@DonIsaac
Copy link
Contributor

You need to change the Path to the LSP binary

@pumano
Copy link
Contributor Author

pumano commented Oct 19, 2024

looks like problem reproduced in 0.10.0 - vscode extension not show any of warn or error for import plugin, while oxlint does. Looks like extension not looking info config "plugins" section while oxlint does.

@stavalfi
Copy link

hi, when will this be released formally in vscode? my team will be happy as well :)

@pumano
Copy link
Contributor Author

pumano commented Oct 26, 2024

@stavalfi you mean import plugin support, or overall support?

@stavalfi
Copy link

stavalfi commented Nov 2, 2024

import plugin support for now, but overall support will be great as well ! Thank you!!

@pumano
Copy link
Contributor Author

pumano commented Nov 4, 2024

Looks like since 0.11.0 import rules working in vscode, but bug not in import plugin, but in some rules which not correctly working in vscode. So I close the issue, and open new with more details.

@pumano pumano closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants