Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast path for checking global IdentifierReference #6505

Closed
Boshen opened this issue Oct 13, 2024 · 1 comment
Closed

Fast path for checking global IdentifierReference #6505

Boshen opened this issue Oct 13, 2024 · 1 comment
Assignees
@Boshen
Labels
C-enhancement Category - New feature or request needs-discussion Requires a discussion from the core team

Comments

@Boshen
Copy link
Member

Boshen commented Oct 13, 2024 •
edited
Loading

I'm going crazy with test cases such as

function foo(undefined) { if (!undefined) { } }

where we need to check whether undefined is a global reference or not 😡
@Boshen Boshen added C-enhancement Category - New feature or request needs-discussion Requires a discussion from the core team labels Oct 13, 2024
@Boshen Boshen self-assigned this Oct 13, 2024
@Boshen Boshen changed the title Add marker to the AST that identifier is a global variable or not Add marker to IdentifierReference for indicating global variable or not Oct 13, 2024
@Boshen Boshen changed the title Add marker to IdentifierReference for indicating global variable or not Fast path for checking global IdentifierReference Oct 13, 2024
@Boshen
Copy link
Member Author

Boshen commented Oct 14, 2024

I managed to fix this issue by juggling Rust in #6549

@Boshen Boshen closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
C-enhancement Category - New feature or request needs-discussion Requires a discussion from the core team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Boshen