Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing disk modal for instance #406

Closed
david-crespo opened this issue Aug 16, 2021 · 1 comment
Closed

Existing disk modal for instance #406

david-crespo opened this issue Aug 16, 2021 · 1 comment

Comments

@david-crespo
Copy link
Collaborator

david-crespo commented Aug 16, 2021

Used on both instance create and instance edit.

Overall pretty simple, but has to fetch existing disks on mount in order to display the dropdown. That's very easy with React Query. Consider adding a refresh button as a proof on concept, just because it's trivial — refetch(). Selection should be preserved on refresh if the selected disk is still present. As with #405, onSubmit should add the selected disk and associated metadata to an array in form state.

Force attach would be reasonably left out for now. In GCP it means attaching an existing disk in read-only mode even if it's already attached to another instance. RFD 4 says "You can only have a disk attached to one instance at a time."

Figma (instance create)

Figma (instance edit)

image

Button here:

image

@david-crespo david-crespo changed the title Create instance: additional volumes, add existing Existing disk modal for instance Aug 18, 2021
@david-crespo
Copy link
Collaborator Author

Visual side more or less done, #732 and #733 are the followups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant