Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires redis-py 2.x #60

Open
breser opened this issue Jan 17, 2019 · 1 comment
Open

Requires redis-py 2.x #60

breser opened this issue Jan 17, 2019 · 1 comment

Comments

@breser
Copy link
Contributor

breser commented Jan 17, 2019

Back in November 2018 redis-py updated to a 3.x version that has breaking changes to it, this tool is not compatible with redis-py 3.x. Noteable reasons why:

  • It no longer coerces input into strings. Right now (at least with python 2.7) is passes unicode values to redis-py which causes it to throw an exception about unicode not having an iteritems method.
  • ttl returns now match Redis' api and negative values imply that there is no ttl. If you dump with redis-py 3.x and then try to load with redis-py 2.x then your keys without ttls will be immediately deleted by redis because it'll set them to negative values rather than setting no ttl.

Tool still works fine if you just always use it with a compatible version or redis-py. I'd suggest adding some code to the tool to error out if you try to use it with a version it's not compatible with and a note in the README.md saying as much.

@p
Copy link
Owner

p commented Jul 23, 2019

I see. As I do not presently use Python I'll leave this issue open for a potential contributor to address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants