Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add --monkeypatch option to pact mock service start up command and pact-provider-verifier command #54

Closed
mefellows opened this issue Nov 7, 2017 · 4 comments

Comments

@mefellows
Copy link
Member

@bethesque commented on Tue Nov 07 2017

Requires standalone version pact-1.19.0.

This is to support: pact-foundation/pact-mock_service#78 and another issue that I can't currently find.

The feature that the user is requesting is not something that should be changed for all users, as it is a non-standard behaviour, and breaks the Rack spec. However, we can allow the underlying code to be monkey patched for his specific use case. The value supplied to --monkeypatch will be an absolute path to a ruby file that will monkeypatch the underlying header logic.

This is not something that we need to document, but we can use it to deal with edge cases when necessary!


@mefellows commented on Tue Nov 07 2017

Moving this to pact-node as that is where the the CLI is integrated.

@oliver-gramberg
Copy link

These are probably the other issues:
pact-foundation/pact-js#14
#24

@mboudreau
Copy link
Contributor

Ick, this smells so bad...

@bethesque
Copy link
Member

Yeah. But please do it anyway ;)

@mboudreau
Copy link
Contributor

mboudreau commented Feb 28, 2018

This has been added in 6.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants