Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verification error message is swallowed #113

Closed
thombergs opened this issue Oct 15, 2017 · 1 comment · Fixed by #114
Closed

verification error message is swallowed #113

thombergs opened this issue Oct 15, 2017 · 1 comment · Fixed by #114

Comments

@thombergs
Copy link
Contributor

When a consumer verification fails, the error message is logged, but not passed upwards to the caller. This means that you always have to look into the logs to find out what went wrong.

For example, using karma-pact, when the tests are run in the browser, you get the output "verification failed" in the browser, but nothing else. Especially when you're starting with Pact, this makes for long bug hunts. It would be nice if the error message directly states what part of the verification failed.

@mefellows
Copy link
Member

The design should be to throw an Error which should bubble up through any Promise chain. To be investigated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants