Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider Verification is broken #22

Closed
mefellows opened this issue Feb 18, 2017 · 0 comments
Closed

Provider Verification is broken #22

mefellows opened this issue Feb 18, 2017 · 0 comments
Assignees
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@mefellows
Copy link
Member

I noticed that the current verify function expects an http response. This is unusual, in most cases we will be calling service collaborators which in turn make the HTTP response calls on our behalf and return back an abstracted object (e.g. in a user service it might return a User object). This means we can only test trivial examples.

See https://github.com/pact-foundation/pact-js/blob/fix/verify/src/pact.js#L103-L116 for an example fix, part of a general API cleanup I'm undertaking with consultation with other community members.

@mefellows mefellows added bug Indicates an unexpected problem or unintended behavior enhancement labels Feb 18, 2017
@mefellows mefellows self-assigned this Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant