build(deps): Fix GitHub warning by updating request from 2.83.0 to 2.87.0 #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Currently a repository including
pact-node
gets the following warnings in the GitHub gui:For
request@2.83.0
, the problem librarycryptiles
was brought in byhawk
:The solution
This PR upgrades
request
. Since later versions of request no longer depend onhawk
orcryptiles
, this will remove the warning in future releases.Aside: The latest version of
request
is actually2.88.0
(as suggested by this dependabot PR). However, the travis build for 2.88.0 fails with lots of test errors, so I don't think we should use it. This is also further evidence that dependabot isn't very useful for us (at least in this configuration).