Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow rack-test 1.x? #164

Closed
ivan-kolmychek opened this issue May 23, 2018 · 3 comments
Closed

Allow rack-test 1.x? #164

ivan-kolmychek opened this issue May 23, 2018 · 3 comments

Comments

@ivan-kolmychek
Copy link

As for 1.26.0, rack-test is locked to ~> 0.6, which matched all versions up to 0.8.3.

The newest version is 1.0.0, since it contains some breaking changes.

Shoud version constraint be updated?
@bethesque
Copy link
Member

Always set CONTENT_TYPE for non-GET requests (Per Lundberg #223)

That breaking change may affect us, as rack-test is used to replay the requests against the mock service, and there is nothing to stop pact users mocking a non-get request with no content type. I'll have to investigate the code to see what the impact is. If you're interested in taking a look and reporting back, that would be awesome.

@BookOfGreg
Copy link
Contributor

Referencing the PR for convenience:
rack/rack-test#223

@BookOfGreg BookOfGreg mentioned this issue Jun 5, 2018
Closed
@bethesque bethesque mentioned this issue Oct 22, 2018
Closed
@bethesque
Copy link
Member

Have updated this to allow 1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bethesque @BookOfGreg @ivan-kolmychek